Skip to content

Commit 07e2198

Browse files
authored
Merge pull request #33 from rafiattrach/rename-download-dir
Rename data/ to m3_data/ to avoid user directory conflicts
2 parents 2c4b744 + 1993302 commit 07e2198

File tree

5 files changed

+29
-10
lines changed

5 files changed

+29
-10
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,3 +79,4 @@ Desktop.ini
7979

8080
# Datasets and other large files
8181
data/
82+
m3_data/

src/m3/cli.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,9 +90,9 @@ def dataset_init_cmd(
9090
"""
9191
Download a supported dataset (e.g., 'mimic-iv-demo') and load it into a local SQLite
9292
93-
Raw downloaded files are stored in a `data/raw_files/<dataset_name>/` subdirectory
93+
Raw downloaded files are stored in a `m3_data/raw_files/<dataset_name>/` subdirectory
9494
and are **not** deleted after processing.
95-
The SQLite database is stored in `data/databases/` or path specified by `--db-path`.
95+
The SQLite database is stored in `m3_data/databases/` or path specified by `--db-path`.
9696
"""
9797
logger.info(f"CLI 'init' called for dataset: '{dataset_name}'")
9898

src/m3/config.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ def _get_project_root() -> Path:
3232

3333

3434
_PROJECT_ROOT = _get_project_root()
35-
_PROJECT_DATA_DIR = _PROJECT_ROOT / "data"
35+
_PROJECT_DATA_DIR = _PROJECT_ROOT / "m3_data"
3636

3737
DEFAULT_DATABASES_DIR = _PROJECT_DATA_DIR / "databases"
3838
DEFAULT_RAW_FILES_DIR = _PROJECT_DATA_DIR / "raw_files"
@@ -63,7 +63,7 @@ def get_dataset_config(dataset_name: str) -> dict | None:
6363
def get_default_database_path(dataset_name: str) -> Path | None:
6464
"""
6565
Return the default SQLite DB path for a given dataset,
66-
under <project_root>/data/databases/.
66+
under <project_root>/m3_data/databases/.
6767
"""
6868
cfg = get_dataset_config(dataset_name)
6969
if cfg and "default_db_filename" in cfg:
@@ -77,7 +77,7 @@ def get_default_database_path(dataset_name: str) -> Path | None:
7777
def get_dataset_raw_files_path(dataset_name: str) -> Path | None:
7878
"""
7979
Return the raw-file storage path for a dataset,
80-
under <project_root>/data/raw_files/<dataset_name>/.
80+
under <project_root>/m3_data/raw_files/<dataset_name>/.
8181
"""
8282
cfg = get_dataset_config(dataset_name)
8383
if cfg:

src/m3/mcp_client_configs/dynamic_mcp_config.py

Lines changed: 22 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,12 @@
1010
from pathlib import Path
1111
from typing import Any
1212

13+
# Error messages
14+
_DATABASE_PATH_ERROR_MSG = (
15+
"Could not determine default database path for mimic-iv-demo.\n"
16+
"Please run 'm3 init mimic-iv-demo' first."
17+
)
18+
1319

1420
class MCPConfigGenerator:
1521
"""Generator for MCP server configurations."""
@@ -165,16 +171,19 @@ def interactive_config(self) -> dict[str, Any]:
165171

166172
if backend == "sqlite":
167173
print("\n📁 SQLite Configuration:")
174+
from m3.config import get_default_database_path
175+
176+
default_db_path = get_default_database_path("mimic-iv-demo")
177+
if default_db_path is None:
178+
raise ValueError(_DATABASE_PATH_ERROR_MSG)
179+
print(f"Default database path: {default_db_path}")
180+
168181
db_path = (
169182
input(
170183
"SQLite database path (optional, press Enter to use default): "
171184
).strip()
172185
or None
173186
)
174-
if db_path:
175-
print(f"✅ Will use database: {db_path}")
176-
else:
177-
print("✅ Will use default database path")
178187

179188
elif backend == "bigquery":
180189
print("\n☁️ BigQuery Configuration:")
@@ -269,6 +278,15 @@ def print_config_info(config: dict[str, Any]):
269278

270279
if "M3_DB_PATH" in server_config["env"]:
271280
print(f"💾 Database path: {server_config['env']['M3_DB_PATH']}")
281+
elif server_config["env"].get("M3_BACKEND") == "sqlite":
282+
# Show the default path when using SQLite backend
283+
from m3.config import get_default_database_path
284+
285+
default_path = get_default_database_path("mimic-iv-demo")
286+
if default_path is None:
287+
raise ValueError(_DATABASE_PATH_ERROR_MSG)
288+
print(f"💾 Database path: {default_path}")
289+
272290
if "M3_PROJECT_ID" in server_config["env"]:
273291
print(f"☁️ Project ID: {server_config['env']['M3_PROJECT_ID']}")
274292

src/m3/mcp_client_configs/setup_claude_desktop.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ def setup_claude_desktop(
160160
print(f"🔧 Backend: {backend}")
161161

162162
if backend == "sqlite":
163-
db_path_display = db_path or "default (data/databases/mimic_iv_demo.db)"
163+
db_path_display = db_path or "default (m3_data/databases/mimic_iv_demo.db)"
164164
print(f"💾 Database: {db_path_display}")
165165
elif backend == "bigquery":
166166
project_display = project_id or "physionet-data"

0 commit comments

Comments
 (0)