Skip to content

Commit fb9126e

Browse files
authored
Merge pull request #711 from rage/pre-release
Fix issues and instructions
2 parents 4ed1d66 + eda9344 commit fb9126e

5 files changed

+9
-7
lines changed

CHANGELOG.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Changelog
22

3-
## [3.0.0]
3+
## [3.0.0] - 2024-01-25
44

55
- Redesigned the user interface
66
- Fixed a bug when changing the exercise directory on Windows

CONTRIBUTING.md

+3-1
Original file line numberDiff line numberDiff line change
@@ -103,13 +103,15 @@ Submit a pull request, and if it fixes problems that have an existing issues on
103103

104104
To release, create a release with the tag in the format `vMAJOR.MINOR.PATCH`, for example `v1.2.3`. For a pre-release version, append `-prerelease` to the tag, for example `v1.2.3-prerelease`.
105105

106-
A script is ran during the release process to ensure that
106+
A script, `./bin/validateRelease.sh`, is ran during the release process to ensure that
107107

108108
- the `CHANGELOG.md` has an entry for the tagged version
109109
- the `package.json` and `package-lock.json` has the same version number as the tagged version
110110

111111
You can update the `package-lock.json` version with `npm i --package-lock-only`.
112112

113+
You can run the script manually by giving the GitHub release tag you're going to use as an argument. For example `./bin/validateRelease.sh v3.0.0-prerelease`.
114+
113115
## Other notes
114116

115117
Running the extension produces the following superfluous warnings:

bin/validateRelease.sh

+4-4
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
exitCode=0
44

5-
if [[ ! $1 =~ ^[v]([0-9]+\.[0-9]+\.[0-9]+(-prerelease)?)$ ]]
5+
if [[ ! $1 =~ ^[v]([0-9]+\.[0-9]+\.[0-9])+(-prerelease)?$ ]]
66
then
77
echo "Error: Input '${1}' did not match the format 'vX.Y.Z[-prerelease]'"
88
exitCode=1
@@ -13,19 +13,19 @@ tagVersion=${BASH_REMATCH[1]}
1313
packageVersion=$(grep -Eo '^ "version": ".+$' package.json | cut -d\" -f4)
1414
if [[ ! $packageVersion =~ $tagVersion ]]
1515
then
16-
echo "Error: The version in package.json '${packageVersion}' doesn't match with the tag '${tagVersion}."
16+
echo "Error: The version in package.json '${packageVersion}' doesn't match with the tag '${tagVersion}'."
1717
exitCode=1
1818
fi
1919

2020
# Make sure that the package-lock.json version also matches
2121
packageLockVersion=$(grep -Eo '"version":.+$' package-lock.json)
2222
if [[ ! $packageLockVersion =~ '"version": "'$tagVersion'",' ]]
2323
then
24-
echo "Error: The version in package-lock.json '${packageVersion}' doesn't match with the tag '${tagVersion}."
24+
echo "Error: The version in package-lock.json '${packageVersion}' doesn't match with the tag '${tagVersion}'."
2525
exitCode=1
2626
fi
2727

28-
# Changelog must have entry matching [X.Y.Z] - YYY-MM-DD
28+
# Changelog must have entry matching [X.Y.Z] - YYYY-MM-DD
2929
# Count the number of matches
3030
changelogEntry=$(grep -Ec "\[""$tagVersion""\] - [0-9]{4}(-[0-9]{2}){2}$" CHANGELOG.md)
3131
if [[ $changelogEntry != 1 ]]

bin/verifyThatLangsBuildsExist.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
const config = require("../config");
2-
const getAllLangsCLIs = require("../src/utils/env").getAllLangsCLIs;
2+
const getAllLangsCLIs = require("../src/utilities/env").getAllLangsCLIs;
33

44
const TMC_LANGS_DL_URL = config.productionApi.__TMC_LANGS_DL_URL__.replace(/"/g, "");
55
const TMC_LANGS_VERSION = config.productionApi.__TMC_LANGS_VERSION__.replace(/"/g, "");
-30.7 KB
Binary file not shown.

0 commit comments

Comments
 (0)