Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platform dependency #13

Open
pprabh2007 opened this issue Dec 5, 2018 · 6 comments
Open

platform dependency #13

pprabh2007 opened this issue Dec 5, 2018 · 6 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@pprabh2007
Copy link

The code cleaner doesnt work on windows

@rahulkumaran rahulkumaran added bug Something isn't working help wanted Extra attention is needed labels Dec 6, 2018
@rahulkumaran
Copy link
Owner

Similar to #2.

@pprabh2007
Copy link
Author

There are primarily three issues with this-

  1. The variable conflict. (only in certain specific test-cases)
  2. Due to different terminal and cmd commands, it does not work with Windows. (in All test-cases)
  3. Another thing is the missing close() statement for file pointers due to which it causes errors in Windows. (in All test-cases)

I primarily referred to points 2 and 3. If you allow me to, I can work on these issues.

I also have a hint of what can be done to improve situation 1, will discuss with you after trying to implement it.

@rahulkumaran
Copy link
Owner

Number 2 makes sense.
But didn't get the 3rd point. Which file pointers are you referring to?

@pprabh2007
Copy link
Author

main_file_ptr.close() statement and temp_file_ptr.close() statement.. missing these statements causes unusual behavior in Windows.. Will post screenshots highlighting the same when I resolve this issue.. thanks

@rahulkumaran
Copy link
Owner

That's a great catch @pprabh2007 . Just realised that too. Sure, please fix it ASAP!

@pprabh2007
Copy link
Author

Thanks.. will send you the PR by tomorrow..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants