-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
platform dependency #13
Comments
Similar to #2. |
There are primarily three issues with this-
I primarily referred to points 2 and 3. If you allow me to, I can work on these issues. I also have a hint of what can be done to improve situation 1, will discuss with you after trying to implement it. |
Number 2 makes sense. |
main_file_ptr.close() statement and temp_file_ptr.close() statement.. missing these statements causes unusual behavior in Windows.. Will post screenshots highlighting the same when I resolve this issue.. thanks |
That's a great catch @pprabh2007 . Just realised that too. Sure, please fix it ASAP! |
Thanks.. will send you the PR by tomorrow.. |
The code cleaner doesnt work on windows
The text was updated successfully, but these errors were encountered: