Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All deployment files contain contracts_version: null #1287

Open
pirapira opened this issue Oct 14, 2019 · 2 comments
Open

All deployment files contain contracts_version: null #1287

pirapira opened this issue Oct 14, 2019 · 2 comments
Labels
efforts: a few hours hack P3 keeping somebody waiting possibly

Comments

@pirapira
Copy link
Contributor

pirapira commented Oct 14, 2019 •
edited
Loading

All deployment files contain meaningless contracts_version: null. #1276 (comment)

Either

  • these contracts_version: null should be removed, or
  • these contracts_version should have correct values.
@pirapira pirapira mentioned this issue Oct 14, 2019
Merged
15 tasks
@nephix
Copy link

nephix commented Feb 28, 2020

It would be nice if the correct contract versions would be exposed in contracts_version

@nephix nephix mentioned this issue Feb 28, 2020
Closed
2 tasks
@andrevmatos
Copy link
Contributor

This is still an issue and requires some hardcoding in our side which is hardly kept up-to-date:
https://github.com/raiden-network/light-client/blob/master/raiden-ts/scripts/versions.js#L9-L15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
efforts: a few hours hack P3 keeping somebody waiting possibly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pirapira @karlb @andrevmatos @nephix