Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change closing_signature into original_signature in updateNonClosingBalanceProof #1292

Open
pirapira opened this issue Oct 16, 2019 · 1 comment
Open

Change closing_signature into original_signature in updateNonClosingBalanceProof #1292

pirapira opened this issue Oct 16, 2019 · 1 comment
Labels
efforts: a few hours hack P1 urgent, blocker, or makes life easier forever

Comments

@pirapira
Copy link
Contributor

Then, in the test scripts, the function can take keyword arguments more easily.

Currently we cannot write **balance_proof._asdict() because online balance proofs contain original_signature.
@pirapira pirapira added blocked-for-feature-freeze P1 urgent, blocker, or makes life easier forever efforts: a few hours hack labels Oct 16, 2019
@pirapira pirapira mentioned this issue Oct 16, 2019
Merged
15 tasks
@karlb
Copy link
Contributor

karlb commented May 28, 2020

Or change original_signature to closing_signature. That would make the naming consistent, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
efforts: a few hours hack P1 urgent, blocker, or makes life easier forever
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pirapira @karlb