Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run make verify_contracts on CONTRACTS_VERSION in the CI builds #1315

Open
pirapira opened this issue Oct 23, 2019 · 1 comment
Open

run make verify_contracts on CONTRACTS_VERSION in the CI builds #1315

pirapira opened this issue Oct 23, 2019 · 1 comment
Labels
efforts: a few hours hack P1 urgent, blocker, or makes life easier forever

Comments

@pirapira
Copy link
Contributor

pirapira commented Oct 23, 2019 •
edited
Loading

This issue keeps track of changing the CI so it fails when the Solidity sources and contracts.json do not match in data_CONTRACTS_VERSION.

When data_CONTRACTS_VERSION/contracts.json and data_CONTRACTS_VERSION/sources do not match, the deployment script refuses to deploy data_CONTRACTS_VERSION/contracts.json. This affects the private network deployment.
@pirapira pirapira added draft P1 urgent, blocker, or makes life easier forever efforts: a few hours hack and removed draft labels Oct 23, 2019
@Dominik1999
Copy link

Find out if there is a use case for using old contracts. We do not see that at the first sight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
efforts: a few hours hack P1 urgent, blocker, or makes life easier forever
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pirapira @Dominik1999