Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GZMTR Transfer Station Bug #326

Open
28yfang opened this issue May 20, 2023 · 5 comments
Open

GZMTR Transfer Station Bug #326

28yfang opened this issue May 20, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@28yfang
Copy link

28yfang commented May 20, 2023

  1. 如视频中所示,当为二线换乘车站时箭头会消失,需刷新页面才会出现
    https://github.com/railmapgen/rmp/assets/123239445/07271d64-de60-4a06-970a-66950874f6d6

  2. 如视频中所示,当为三线换乘车站时:

    1. 未加颜色时箭头显示正常;
    2. 加前两条线路的颜色时箭头仍为灰色;
    3. 加完第三条线路的颜色后箭头会消失不见,需刷新页面才会出现
      https://github.com/railmapgen/rmp/assets/123239445/610117fd-8968-4045-84ec-b2cfc6fa2393
@thekingofcity thekingofcity self-assigned this May 20, 2023
@thekingofcity thekingofcity added the bug Something isn't working label May 20, 2023
@28yfang
Copy link
Author

28yfang commented Aug 1, 2023

Update: This problem only appears in mobile.

@langonginc
Copy link
Member

It appears on my Safari (Mac)

@thekingofcity
Copy link
Member

Hi, I can not reproduce this on Firefox.

@wongchito
Copy link
Member

wongchito commented Feb 14, 2024

@thekingofcity

I think the <path> element with marker-start marker-mid marker-end needs to be re-drawn after the related <marker> is added to the DOM. Consider a 2-step rendering or re-rendering of the station node?

This issue occurs in all WebKit browsers (Chrome, Edge, Safari), which covers over 30% of the global population.

@thekingofcity
Copy link
Member

I think the <path> element with marker-start marker-mid marker-end needs to be re-drawn after the related <marker> is added to the DOM. Consider a 2-step rendering or re-rendering of the station node?

Do we have any implementation reference for this 2-step rendering? Do we need to remove and reinsert the path elements from the DOM manually? Or a simple rerender from state change is suffice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

4 participants