Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better vertical station name offset and font size in JR East stations #795

Closed
M-ult opened this issue Aug 18, 2024 · 6 comments
Closed

Better vertical station name offset and font size in JR East stations #795

M-ult opened this issue Aug 18, 2024 · 6 comments
Labels
bug Something isn't working
Milestone

Comments

@M-ult
Copy link

M-ult commented Aug 18, 2024

Dear Developers,

Thank you very much for your tireless work in building this platform for creating roadmaps. As a roadmap enthusiast, I still remember the joy I felt when I first discovered and used this platform. Over time, I've encountered a few issues that have arisen along with version changes, probably starting with version 3.5.38(If I remember correctly the version was updated during the May Day Labor Day Holiday).

  1. JR东日本基本车站下,“名称偏移”选择底部,打开“垂直名称”--站名文字与路线贴的过近以至于会覆盖到路线上;在这种情况下再打开“重要车站”,站名明显不居中于黑框而是向上偏移(详见下图所示)
    Q1

  2. JR东日本基本车站下,打开“重要车站”,“名称偏移”选择左或右--黑框内的文字并没有居中显示而是向下微偏移(详见下图所示)
    Q2

  3. JR东日本重要车站以及其“最重要车站”的黑框大小。窃以为3.5.38版本之前的两者黑框大小显示是合理的,也正基于此开始着手构建JR东日本样式的路线图。但从3.5.38开始:原本的“JR东日本重要车站”黑框变为原本其“最重要车站”的黑框大小;而原本的其“最重要车站”的黑框大小也比原先大了一倍。(也就是两者的黑框都大了一倍)。从之前构建的路线图角度以及参考现实中官方pdf版本来看,鄙人认为是不合理的,望能将两者调整回原先的黑框大小。

  4. 路线在虚拟节点的连接下,导出图片(无论PNG还是SVG)后会产生细黑线,该问题从JR东日本样式上线开始存在至今。虽不是什么大问题,但窃以为难免影响美观(详见下图所示)
    Q4

These are the bug issues I'm having. I look forward to your valuable comments and hope RMP will become more and more powerful.

@thekingofcity thekingofcity added the bug Something isn't working label Aug 18, 2024
@thekingofcity
Copy link
Member

Hi, thanks for sharing the problems and details.

We're currently under the v5 development but I'm pretty sure that this will be the first bug fix after the v5 release.

@thekingofcity thekingofcity modified the milestones: rmp 5.1, rmp 5.0 Aug 18, 2024
@thekingofcity thekingofcity changed the title Some bugs under JR east style Better station name offset in JR East basic station vertical Sep 23, 2024
@thekingofcity
Copy link
Member

Hi, thanks for your patience. I go through your questions and either fix or explain them below. For testing them before final release, head to https://uat-railmapgen.github.io/?app=rmp

  1. fixed.
    image

  2. I'm wondering if you are not loading the correct "M PLUS 2" font correctly.
    image

  3. The font size of JR East important station is enlarged from 10 to 15 in 3.5.37. From the official map, I would argue that the font size of 東京 and 上野 is different from 神田 and 御茶ノ水. The only question here is how large it will be, 12, 13, 14, or 15?
    image

  4. This is a known issue and the technical reason could be explained here. Line stop style could eliminate this problem by having all the lines strokeLinecap=round.

Bests,
thekingofcity

@M-ult
Copy link
Author

M-ult commented Sep 24, 2024

Dear developers,

Thank you for your work on fixing the above bugs.

Regarding the 3rd issue, I think there are some specifications that should be followed:

  1. The size of "Important station" under "JR East basic station" should be the same as "JR East important station". In reality, the two types of stations should have the same status (e.g. "西船橋" and "南船橋"). The "Important station" under "JR East basic station" is a box added to the text because there is not enough space to put the black box directly over the line. (However, in the official PDF file, "錦糸町" is the only exception. The black box is rather large for it, which I tend to think is a lack of rigor on the part of the officials, as this map doesn't follow the strict 45° and 90° alignments, either.)
    test

  2. Since you mentioned a numerical value above, "The font size of JR East important station is enlarged from 10 to 15 in 3.5.37". In view of the above, I think that the size of "JR East important station" should be resized to 10, and the size of "Most important station" under "JR East important station" should be resized to 15, then the size of “Important station” under "JR East basic station" should also be changed to 10.

I hope my idea can be used for your reference.

@thekingofcity
Copy link
Member

thekingofcity commented Sep 25, 2024

Yes, you're right. I mixed those and thanks for pointing them out.

Font size is changed back to 10 and try it at https://uat-railmapgen.github.io/?app=rmp

@thekingofcity
Copy link
Member

Hi @M-ult, if everything goes well, can we merge those fixes? Or is there anything unresolved?

@M-ult M-ult closed this as completed Sep 26, 2024
@thekingofcity thekingofcity changed the title Better station name offset in JR East basic station vertical Better vertical station name offset and font size in JR East stations Sep 26, 2024
@thekingofcity
Copy link
Member

Hi, this fix is available on version 5.0.34 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants