-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor the image credits styles in old blog posts #289
Comments
is this still relevant? If yes, could you provide a little more context or which posts this would apply to? I'm just beginning but would like to help :) |
Hi @frefell . Thanks for your interest. This is still relevant. The issue here is we have old posts which are not using image-credits style. You can check 2015 and 2014 posts. And for example you can check 2017 posts which are using image-credit style. I think you can start with picking the file -> 2015-10-30-cocoagems-get-strange-at-strangeloop.md. |
Thanks for clarifying. I will start with 2015 then :) |
contribution to issue rails-girls-summer-of-code#289
Fixed blog posts of 2017 (273a9c5) |
thank you @mkalininait ! \o/ |
@alicetragedy are the only pieces remaining on this the 2016 posts? |
@MasonHolland yes, I think so! I'd probably have to double-check to make sure that nothing else is missing, but please don't let that stop you from contributing :) If you're interested in cleaning up the 2016, go ahead — in the meanwhile I'll take a look at what we have so far and if there's any older posts we might have missed. |
@MasonHolland just wondering — are you interested in working on this issue? Is there anything I can do to help? |
@alicetragedy- Hi! I’m a first-time contributor and was hoping to help out with this issue & I noticed in the comments that @MasonHolland is working on it. I'd love to help, and wanted to check in on the current status for this issue. Is there currently a solution in progress? |
hej @wiseemily88 — thank you so much for your interest in helping out 💖I haven't heard anything back from @MasonHolland so my suggestion would be that you just go ahead and pick up this issue, if you want to work on it. |
In one of the last contributions to the blog, the inline styling we use for image credits/descriptions was moved to its own class in a css file. Since we'll be sticking to that convention in the future (to have as little code in the single post files as possible) I'd like to fix all of the past posts as well to use that same convention.
The text was updated successfully, but these errors were encountered: