Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for PredicateBuilderTest #1239

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Fix for PredicateBuilderTest #1239

merged 1 commit into from
Oct 7, 2024

Conversation

aidanharan
Copy link
Contributor

@aidanharan aidanharan commented Oct 7, 2024

Fix for PredicateBuilderTest. Not sure why tests suddenly failing.

https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/actions/runs/11208481488/job/31152221363

  1) Error:
ActiveRecord::PredicateBuilderTest#test_registering_new_handlers_for_association_coerced:
NameError: undefined local variable or method `topic_title' for an instance of ActiveRecord::PredicateBuilderTest
    /usr/local/bundle/bundler/gems/rails-967c33d493e5/activerecord/lib/active_record/test_fixtures.rb:280:in `method_missing'
    test/cases/coerced_tests.rb:1341:in `test_registering_new_handlers_for_association_coerced'

  2) Error:
ActiveRecord::PredicateBuilderTest#test_registering_new_handlers_coerced:
NameError: undefined local variable or method `topic_title' for an instance of ActiveRecord::PredicateBuilderTest
    /usr/local/bundle/bundler/gems/rails-967c33d493e5/activerecord/lib/active_record/test_fixtures.rb:280:in `method_missing'
    test/cases/coerced_tests.rb:1335:in `test_registering_new_handlers_coerced'

@aidanharan aidanharan marked this pull request as ready for review October 7, 2024 13:06
@aidanharan aidanharan merged commit ee8eba9 into main Oct 7, 2024
3 of 4 checks passed
@aidanharan aidanharan deleted the fix-predicate-builder-test branch October 7, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant