Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI for Rails 8.1 #1267

Merged
merged 4 commits into from
Dec 8, 2024
Merged

Fix CI for Rails 8.1 #1267

merged 4 commits into from
Dec 8, 2024

Conversation

aidanharan
Copy link
Contributor

@aidanharan aidanharan commented Dec 8, 2024

Get the tests to run against the Rails main branch.

Also, fix the following statement pool issue in the tests.

https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/actions/runs/12222831116/job/34093612408

/usr/local/bundle/bundler/gems/rails-410ad1c8a18e/activerecord/test/cases/connection_adapters/statement_pool_test.rb:8:in `<class:StatementPoolTest>': uninitialized constant ActiveRecord::ConnectionAdapters::StatementPoolTest::StatementPool (NameError)

      class TestPool < StatementPool
                       ^^^^^^^^^^^^^
	from /usr/local/bundle/bundler/gems/rails-410ad1c8a18e/activerecord/test/cases/connection_adapters/statement_pool_test.rb:7:in `<module:ConnectionAdapters>'
	from /usr/local/bundle/bundler/gems/rails-410ad1c8a18e/activerecord/test/cases/connection_adapters/statement_pool_test.rb:6:in `<module:ActiveRecord>'
	from /usr/local/bundle/bundler/gems/rails-410ad1c8a18e/activerecord/test/cases/connection_adapters/statement_pool_test.rb:5:in `<top (required)>'
	from /usr/local/lib/ruby/3.3.0/bundled_gems.rb:69:in `require'
	from /usr/local/lib/ruby/3.3.0/bundled_gems.rb:69:in `block (2 levels) in replace_require'
	from /usr/local/bundle/gems/rake-13.2.1/lib/rake/rake_test_loader.rb:21:in `block in <main>'
	from /usr/local/bundle/gems/rake-13.2.1/lib/rake/rake_test_loader.rb:6:in `select'
	from /usr/local/bundle/gems/rake-13.2.1/lib/rake/rake_test_loader.rb:6:in `<main>'

@aidanharan aidanharan changed the title Require statement pool Fix CI Dec 8, 2024
@aidanharan aidanharan changed the title Fix CI Fix CI for Rails 8.1 Dec 8, 2024
@aidanharan aidanharan marked this pull request as ready for review December 8, 2024 18:09
@aidanharan aidanharan merged commit 0afebac into main Dec 8, 2024
2 of 4 checks passed
@aidanharan aidanharan deleted the fix-ci-8.1.0 branch December 8, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant