"header already sent" on cache miss when ActionController::Live is included #83
Comments
|
Ran into this myself, same line causing the issue with Did you find a workaround? |
|
I didn't need most of - include ActiveStorage::Streaming
+ include ActionController::DataStreaming |
|
I ended up doing this: require 'action_controller/caching/actions'
# Workaround for known issue
# https://github.com/rails/actionpack-action_caching/issues/83
module ActionController
module Caching
module Actions
class ActionCacheFilter
alias_method :original_around, :around
def around(controller)
original_around(controller) { yield }
rescue ActionDispatch::IllegalStateError => e
Rails.logger.error(
"Silenced ActionPack / IllegalStateError: #{e.message}"
)
end
end
end
end
end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Given a controller
calling
/articleswith an empty cache triggers the error below. The page is rendered and cached correctly despite the error in the log.Expected behavior
The page should be rendered and cached correctly (as it is) and there should not be any error in the log.
Notes
In my case,
ActionController::Livewas included transitively byinclude ActiveStorage::Streaming.The problem is caused by setting content type at the end of around filter. At that point, the response is already commited if
ActionController::Liveis included.actionpack-action_caching/lib/action_controller/caching/actions.rb
Line 171 in 05c821e
The page is still rendered and cached correctly, because it was already submitted before the error is triggered. The error is not present in following requests which hit the cache.
I was able to reproduced it in a blank rails application, with a single controller generated by scaffolding.
Versions
The text was updated successfully, but these errors were encountered: