ledger clear signing upgrades #5966

DanielSinclair · 2024-07-30T06:12:07Z

Fixes APP-####

What changed (plus any additional context for devs)

Upgraded @ledgerhq/hw-app-eth and @ledgerhq/react-native-hw-transport-ble
The upstream issue that required the patch was corrected.
These upgrades will allow for Clear Signing with newer Ledger firmware versions

Requires https://github.com/rainbow-me/rainbow-scripts/pull/183

Screen recordings / screenshots

Screen.Recording.2024-10-10.at.12.54.58.PM.mov

What to test

Pairing and Signing with Ledger devices. Should try on a Ledger with an older firmware version and a recent firmware version (this month)
Signing for popular dApps like Lido or Uniswap should not display a Blind Signing warning (new aggressive warning)

socket-security · 2024-07-30T06:13:12Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@ledgerhq/[email protected]	None	`0`	3.1 MB	ldg-github-ci
npm/@ledgerhq/[email protected]	None	`0`	223 kB	ldg-github-ci
npm/@ledgerhq/[email protected]	None	`0`	142 kB	ldg-github-ci
npm/@ledgerhq/[email protected]	None	`0`	208 kB	ldg-github-ci
npm/@ledgerhq/[email protected]	None	`0`	135 kB	ldg-github-ci
npm/@ledgerhq/[email protected]	None	`0`	2.21 MB	ldg-github-ci
npm/@ledgerhq/[email protected]	None	`0`	108 kB	ldg-github-ci
npm/@ledgerhq/[email protected]	None	`0`	133 kB	ldg-github-ci
npm/@ledgerhq/[email protected]	None	`0`	266 kB	aboissiere, gbrahm-ledger, ldg-github-ci, ...5 more
npm/@ledgerhq/[email protected]	None	`0`	324 kB	ldg-github-ci
npm/@ledgerhq/[email protected]	None	`0`	377 kB	ldg-github-ci
npm/[email protected]	network	`0`	2.14 MB	jasonsaayman
npm/[email protected]	None	`0`	487 kB	evanvosberg
npm/[email protected]	None	`0`	5.55 kB	junderw
npm/[email protected]	environment	`0`	4.51 MB	react-bot
npm/[email protected]	None	`0`	1.89 MB	dominik-czupryna-withintent
npm/[email protected]	None	`0`	64.3 kB	piotrwitek

🚮 Removed packages: npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

DanielSinclair · 2024-07-30T06:23:37Z

@BrodyHughes Have two of these PRs for App and BX related to a Ledger change to Blind Signing warnings. Just need to test that Ledger functionality is still working as expected. We are in the process of submitting metadata for our contracts to remove warnings which might be a follow-up. More details here: https://linear.app/rainbow/issue/APP-1731/ledger-removal-of-blind-signing

ibrahimtaveras00

I am unable to import via ledger on both OS's

Android: crashes after allowing permission

Screen.Recording.2024-08-07.at.2.13.47.PM.mov

iOS: TF = 1.9.34 (34)
Hangs during looking stage (I have the app open, 5 min has passed and still looking)

RPReplay_Final1723054955.MP4

walmat · 2024-08-09T15:28:52Z

I don't have a ledger so can't really review this PR. Going to remove my request for review.

BrodyHughes · 2024-09-25T19:50:46Z

Adding my slack comment here so we don't lose it:

Ledger testing:

TF 1.9.41 (6)
Ledger Nano X
Hardware: Ledger NanoX V2.0
Firmware: Secure Element v2.2.3 // Microcontroller 2.30 // Bootloader 1.16

okay i’m not sure if the app is even asking for bluetooth permissions correctly? i am also stuck on the import flow trying to connect to ledger.

can confirm:

connects to phone bluetooth
connects to ledger live app
ledger live settings show bluetooth permissions allowed
rainbow does NOT show bluetooth permissions allowed
rainbow does NOT prompt me for bluetooth permissions

chore: upgrade ledgerhq depens, remove patch The upstream issue that required the patch was corrected. These upgrades will allow for Clear Signing with new Ledger firmware versions chore: upgrade @ledgerhq/hw-app-eth chore: upgrade to new versions

…bump-ledger

fixed

brunobar79 · 2024-10-10T18:30:41Z

metro.config.js

@@ -31,6 +31,50 @@ if (process.env.CI) {
 const rainbowConfig = {
  resolver: {
    blacklistRE,
+    resolveRequest: (context, moduleName, platform) => {


This is required to resolve ledger packages correctly otherwise it won't find them.

brunobar79 · 2024-10-10T18:31:21Z

src/handlers/LedgerSigner.ts

-        transport => {
-          const eth = new AppEth(transport);
-          return eth;
+      getEthApp(deviceId).then(


using .then vs await to keep it compatible with the Signer interface

brunobar79 · 2024-10-10T18:32:26Z

src/model/wallet.ts

      return new LedgerSigner(provider, getHdPath({ type: WalletLibraryType.ledger, index: Number(index) }), deviceId);
    }
  } else if (privateKey) {
-    return new Wallet(privateKey, provider || web3Provider);


This is the line I mentioned before. Now the provider defaults to mainnet instead of being undefined.

brunobar79 · 2024-10-10T18:33:00Z

src/screens/SendSheet.tsx

@@ -170,7 +170,7 @@ export default function SendSheet() {
  const [debouncedRecipient] = useDebounce(recipient, 500);

  const [isValidAddress, setIsValidAddress] = useState(!!recipientOverride);
-  const [currentProvider, setCurrentProvider] = useState<StaticJsonRpcProvider | undefined>();
+  const [currentProvider, setCurrentProvider] = useState<StaticJsonRpcProvider | undefined>(getProvider({ chainId: ChainId.mainnet }));


Provider now defaulting to mainnet. Before it was undefined (breaking ledger mainnet sends)

brunobar79 · 2024-10-10T19:42:55Z

Launch in simulator or device for c0e322f

ibrahimtaveras00

All issues have been resolved, QA Passed 👍🏽

brunobar79 · 2024-10-11T00:05:16Z

Launch in simulator or device for 4e8afdf

derHowie

changes lgtm 🫡

…bump-ledger

brunobar79 · 2024-10-15T16:29:07Z

Launch in simulator or device for 3d06921

walmat

lgtm

DanielSinclair requested a review from BrodyHughes July 30, 2024 06:16

brunobar79 marked this pull request as ready for review August 5, 2024 20:35

brunobar79 requested review from walmat, benisgold and jinchung as code owners August 5, 2024 20:35

ibrahimtaveras00 previously requested changes Aug 7, 2024

View reviewed changes

jinchung removed their request for review August 8, 2024 20:12

walmat removed their request for review August 9, 2024 15:28

DanielSinclair marked this pull request as draft August 21, 2024 17:15

DanielSinclair force-pushed the @daniel/bump-ledger branch 2 times, most recently from 007b0d1 to bc3c8fa Compare August 26, 2024 17:33

DanielSinclair force-pushed the @daniel/bump-ledger branch 2 times, most recently from d07451b to 97f9afb Compare September 24, 2024 18:21

brunobar79 and others added 2 commits October 1, 2024 16:16

fix build

404a7ec

DanielSinclair force-pushed the @daniel/bump-ledger branch from 97f9afb to 606f42b Compare October 1, 2024 20:28

brunobar79 added 2 commits October 8, 2024 13:26

Merge branch 'develop' of github.com:rainbow-me/rainbow into @daniel/…

7128272

…bump-ledger

ledger working again

01ca5a3

brunobar79 added 3 commits October 9, 2024 13:57

set default provider as mainnet

0bacbd6

clean console logs

ba68d52

fix conflicts

85a7241

brunobar79 marked this pull request as ready for review October 10, 2024 18:30

brunobar79 reviewed Oct 10, 2024

View reviewed changes

brunobar79 requested review from jinchung, walmat and derHowie and removed request for BrodyHughes, benisgold and jinchung October 10, 2024 18:33

fix merge conflicts

48fd4eb

ibrahimtaveras00 approved these changes Oct 10, 2024

View reviewed changes

brunobar79 added the release for release blockers and release candidate branches label Oct 11, 2024

derHowie approved these changes Oct 11, 2024

View reviewed changes

Merge branch 'develop' of github.com:rainbow-me/rainbow into @daniel/…

534e3f6

…bump-ledger

walmat approved these changes Oct 15, 2024

View reviewed changes

brunobar79 merged commit b191fef into develop Oct 15, 2024
8 checks passed

brunobar79 deleted the @daniel/bump-ledger branch October 15, 2024 17:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ledger clear signing upgrades #5966

ledger clear signing upgrades #5966

DanielSinclair commented Jul 30, 2024 •

edited by brunobar79

Loading

socket-security bot commented Jul 30, 2024 •

edited

Loading

DanielSinclair commented Jul 30, 2024

ibrahimtaveras00 left a comment •

edited

Loading

walmat commented Aug 9, 2024

BrodyHughes commented Sep 25, 2024

brunobar79 Oct 10, 2024

brunobar79 Oct 10, 2024

brunobar79 Oct 10, 2024

brunobar79 Oct 10, 2024

brunobar79 commented Oct 10, 2024

ibrahimtaveras00 left a comment

brunobar79 commented Oct 11, 2024

derHowie left a comment

brunobar79 commented Oct 15, 2024

walmat left a comment

ledger clear signing upgrades #5966

ledger clear signing upgrades #5966

Conversation

DanielSinclair commented Jul 30, 2024 • edited by brunobar79 Loading

What changed (plus any additional context for devs)

Screen recordings / screenshots

What to test

socket-security bot commented Jul 30, 2024 • edited Loading

DanielSinclair commented Jul 30, 2024

ibrahimtaveras00 left a comment • edited Loading

Choose a reason for hiding this comment

walmat commented Aug 9, 2024

BrodyHughes commented Sep 25, 2024

brunobar79 Oct 10, 2024

Choose a reason for hiding this comment

brunobar79 Oct 10, 2024

Choose a reason for hiding this comment

brunobar79 Oct 10, 2024

Choose a reason for hiding this comment

brunobar79 Oct 10, 2024

Choose a reason for hiding this comment

brunobar79 commented Oct 10, 2024

ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

brunobar79 commented Oct 11, 2024

derHowie left a comment

Choose a reason for hiding this comment

brunobar79 commented Oct 15, 2024

walmat left a comment

Choose a reason for hiding this comment

DanielSinclair commented Jul 30, 2024 •

edited by brunobar79

Loading

socket-security bot commented Jul 30, 2024 •

edited

Loading

ibrahimtaveras00 left a comment •

edited

Loading