[chore]: Remove old logger and cleanup logging#6021
Merged
Conversation
jinchung
reviewed
Aug 22, 2024
jinchung
reviewed
Aug 22, 2024
jinchung
reviewed
Aug 22, 2024
jinchung
reviewed
Aug 22, 2024
jinchung
reviewed
Aug 22, 2024
jinchung
reviewed
Aug 22, 2024
jinchung
reviewed
Aug 22, 2024
| "lint": "yarn format:check && yarn lint:ts && yarn lint:js", | ||
| "lint:ci": "yarn format:check && yarn lint:ts && yarn lint:js --quiet", | ||
| "lint:js": "eslint --cache .", | ||
| "lint:ci": "yarn format:check && yarn lint:ts && yarn lint:js", |
Member
There was a problem hiding this comment.
making a note to make sure you want to keep these changes (not sure if it was while you were testing things)
Contributor
Author
There was a problem hiding this comment.
Yeah so the --quiet flag previously wasn't doing anything. Attaching it on the js lint silences warnings (which I prefer and it speeds up linting by a significant amount since the console doesn't have to log 1000+ warnings).
TLDR: This was intentional
jinchung
approved these changes
Aug 22, 2024
Member
jinchung
left a comment
jinchung
left a comment
There was a problem hiding this comment.
🌮 added a few comments just to make sure things were as intended - none are blockers
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed (plus any additional context for devs)
Cleaned up the references to the old deprecated logger in
@utils/loggerand replaced the calls with@/logger. Also went ahead and added string references to the front of the logs to help us located the file that the log is coming from. This should help us debug quicker where an error is originating from. Along with all this work, I removed several instances in the app that calledlogger.infowhich sends a message to Sentry every time it's called and replaced it withlogger.debugwhich is just added as a breadcrumb. This should help clean up events on Sentry that don't really have a purpose to be there.