Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Android navigation mode detection #6053

Merged
merged 5 commits into from
Aug 30, 2024
Merged

Fix Android navigation mode detection #6053

merged 5 commits into from
Aug 30, 2024

Conversation

walmat
Copy link
Contributor

@walmat walmat commented Aug 28, 2024

Fixes APP-1824
Fixes #5527

What changed (plus any additional context for devs)

  • adds a native module that properly calculates the navbar height on Android devices
  • calculates navbar height / device scale and changes the navbar system color to transparent if less then 40

Screen recordings / screenshots

What to test

@walmat walmat requested review from brunobar79 and benisgold August 28, 2024 17:05
@linear Linear
Copy link

linear bot commented Aug 28, 2024

APP-1824 App navigation covered by Android navigation bar

@walmat walmat requested a review from welps August 28, 2024 18:13
@walmat walmat merged commit 265bc25 into develop Aug 30, 2024
5 checks passed
@walmat walmat deleted the @matthew/APP-1824 branch August 30, 2024 17:40
@bernaferrari
Copy link

calculates navbar height / device scale and changes the navbar system color to transparent if less then 40

You can make the navbar system color transparent always, that's Android 15 default I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benisgold benisgold benisgold approved these changes

@brunobar79 brunobar79 Awaiting requested review from brunobar79

@welps welps Awaiting requested review from welps

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App navigation covered by Android navigation bar
3 participants
@walmat @bernaferrari @benisgold