Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove p-queue #6063

Merged
merged 2 commits into from
Aug 29, 2024
Merged

fix: remove p-queue #6063

merged 2 commits into from
Aug 29, 2024

Conversation

derHowie
Copy link
Member

@derHowie derHowie commented Aug 29, 2024

fixes APP-1829

What changed (plus any additional context for devs)

See ticket description for slack thread detailing the 3 crashes found during regression

What to test

Should be able to press pfp on home. Should be able to advance through the send flow from expanded state and via send button w/o issues

Copy link

socket-security bot commented Aug 29, 2024

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/[email protected])

View full report↗︎

@derHowie derHowie marked this pull request as ready for review August 29, 2024 17:02
Copy link

linear bot commented Aug 29, 2024

@derHowie derHowie requested review from walmat and benisgold August 29, 2024 17:06
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All crashes have been fixed on both OS's, QA Passed ✅

@derHowie derHowie merged commit 349bd22 into develop Aug 29, 2024
4 of 5 checks passed
@derHowie derHowie deleted the @chris/remove-p-queue branch August 29, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants