Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE]: Remove Swaps V1 Dead Code #6181

Merged
merged 41 commits into from
Oct 31, 2024
Merged

[CHORE]: Remove Swaps V1 Dead Code #6181

merged 41 commits into from
Oct 31, 2024

Conversation

walmat
Copy link
Contributor

@walmat walmat commented Oct 9, 2024 •
edited by ibrahimtaveras00
Loading

Fixes

What Changed

The gist of this feature branch is removing swaps v1 dead code and cleaning up traces in components.

There is no added functionality in this branch. No regressions should take place.

Screenshots / Screen Recordings

// coming soon

What To Test

  • Entering swaps flow
    • From expanded state
      • From on other networks button in expanded state
    • From discover search
    • From profile button
    • Blocked on the above for read-only wallets
  • Buy button prompts AddCashSheet
    • Blocked on above for read-only wallets
  • Send button prompts SendSheet
    • Blocked on above for read-only wallets
  • Gas speed buttons sanity check
  • Custom gas panel functionality outside of swaps
  • Custom gas panel functionality inside of swaps
  • Test token search in discover
  • Test cross-chain swaps
  • Test bridges
  • Test same chain swaps
  • Test unlock + swap

walmat
walmat commented Oct 9, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@brunobar79
Copy link
Member

Launch in simulator or device for c8412d6

@brunobar79
Copy link
Member

Launch in simulator or device for bcf39fd

@walmat walmat changed the title [FEAT]: Remove Swaps V1 [FEAT]: Remove Swaps V1 Dead Code Oct 9, 2024
@brunobar79
Copy link
Member

Launch in simulator or device for 59c5d28

@brunobar79
Copy link
Member

Launch in simulator or device for a2bae64

@brunobar79
Copy link
Member

Launch in simulator or device for 2726199

@brunobar79
Copy link
Member

Launch in simulator or device for 87e551c

walmat added 3 commits October 22, 2024 10:55
@walmat
chore: merge
1cc9d12
@walmat
Swaps v2 cleanup duplicates / unused utils (#6202)
85bf5ff 
* remove bunch of duplicate utils

* remove unused hooks and remove duplicate AnimatedBlurView

* remove multiple getUniqueIds and only keep worklet version
@walmat
reorder worklets
dbe91b6
@walmat walmat requested review from jinchung and benisgold October 22, 2024 17:17
@brunobar79
Copy link
Member

Launch in simulator or device for e0a3fca

@brunobar79
Copy link
Member

Launch in simulator or device for ab96328

jinchung
jinchung approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@jinchung jinchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@brunobar79
Copy link
Member

Launch in simulator or device for 947035e

ibrahimtaveras00
ibrahimtaveras00 requested changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://linear.app/rainbow/issue/APP-1973/6181-qa-bug-epic

walmat added 2 commits October 30, 2024 10:13
@walmat
fix gas button stuck on loading (#6241)
12635e4 
* fix gas button issues?

* rm poll causing infinite loop

* remove some weird checks

* maybe?
@walmat
move unused vars to swaps util
4094a69
jinchung
jinchung reviewed Oct 31, 2024
View reviewed changes
src/components/sheet/sheet-action-buttons/SendActionButton.js
}
: { ...updatedParams };
navigate(Routes.SEND_FLOW, {
asset,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this mean we don't need this asset on line 15 anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do for Android

@jinchung jinchung self-requested a review October 31, 2024 12:01
jinchung
jinchung approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@jinchung jinchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

ibrahimtaveras00
ibrahimtaveras00 approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all issues have been resolved, QA Passed 👍🏽

@jinchung jinchung merged commit f531f8c into develop Oct 31, 2024
9 of 10 checks passed
@jinchung jinchung deleted the feat/remove-swaps-v1 branch October 31, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

@benisgold benisgold benisgold approved these changes

@jinchung jinchung jinchung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@walmat @brunobar79 @jinchung @benisgold @ibrahimtaveras00