fix position total value display #6185
Conversation
greg-schrammel
requested review from
walmat,
benisgold,
estebanmino and
derHowie
src/resources/defi/utils.ts
Outdated
| * omittedTotal is the total WITHOUT the positions that are omitted | ||
| * used for the total wallet balance, the position card still shows the normal total | ||
| */ | ||
| omittedTotal: { |
There was a problem hiding this comment.
found this name (ommitedTotal) kinda confusing but couldn't think of anything better, lmk if you think of a more descriptive name
There was a problem hiding this comment.
idk maybe totalWithOmissions?
also ommited is spelled omitted btw
There was a problem hiding this comment.
i think it would be a lot more clear if we first came up for a name for the types of positions that are being excluded. i'm still unclear on this. what dequalifies a position from having it's value being included in the total wallet balance?
src/resources/defi/utils.ts
Outdated
| totalBorrows = add(totalBorrows, nativeDisplay.amount); | ||
|
|
||
| if (borrow.omit_from_total) { | ||
| totalOmittedFromTotals = subtract(totalOmittedFromTotals, nativeDisplay.amount); |
There was a problem hiding this comment.
this make sense? we add the others but subtract the borrows
There was a problem hiding this comment.
I mean it works right, not sure if I missed some edge case
|
@greg-schrammel, code looks good but I'm unsure what to test. Is the moxie case the only thing I should test or are there other considerations? |
yeah the only positions I know that can have the |
brunobar79
added
release
src/resources/defi/utils.ts
Outdated
| * omittedTotal is the total WITHOUT the positions that are omitted | ||
| * used for the total wallet balance, the position card still shows the normal total | ||
| */ | ||
| omittedTotal: { |
There was a problem hiding this comment.
idk maybe totalWithOmissions?
also ommited is spelled omitted btw
src/resources/defi/utils.ts
Outdated
| * omittedTotal is the total WITHOUT the positions that are omitted | ||
| * used for the total wallet balance, the position card still shows the normal total | ||
| */ | ||
| omittedTotal: { |
There was a problem hiding this comment.
i think it would be a lot more clear if we first came up for a name for the types of positions that are being excluded. i'm still unclear on this. what dequalifies a position from having it's value being included in the total wallet balance?
greg-schrammel
deleted the
gregs/app-1920-display-moxie-positions-usd-value-in-wallet-correctly
branch
Fixes APP-####
What changed (plus any additional context for devs)
some positions are omitted from the total wallet balance, but should still display the position value in the position card
Screen recordings / screenshots
before/after
What to test