Remove direct usage of web3Provider by jinchung · Pull Request #6200 · rainbow-me/rainbow

jinchung · 2024-10-13T20:44:51Z

Fixes APP-1925

What changed (plus any additional context for devs)

As part of removing the direct import and usage of web3Provider, I made some functions require a mandatory provider param
Moved over to using the getProvider function

Screen recordings / screenshots

Sending:
https://github.com/user-attachments/assets/9448ddff-7413-43c2-847b-3075125599e7

Offline toast:
https://github.com/user-attachments/assets/b361229c-65f8-434f-b96e-c795cf3cab76

What to test

sending on various networks
executing swap transactions on various networks
WalletConnect transactions and message signing
speed up and cancel txns across various networks
check OfflineToast behaves as expected
updating Showcase behaves as expected

linear · 2024-10-13T20:44:53Z

APP-1925 Remove all direct imports and usage of web3Provider

jinchung · 2024-10-15T16:20:52Z

  const isConnected = useInternetStatus();
-  const { network } = useAccountSettings();
-  const providerUrl = web3Provider?.connection?.url;
-  const isMainnet = network === Network.mainnet && !providerUrl?.startsWith('http://');


the only reason the web3Provider was used here was to check the provider URL to see if it's the hardhat URL; moved it over to using the new connectedToHardhat instead

jinchung · 2024-10-15T16:31:31Z

        throw new RainbowError('Points: Error loading wallet');
      }
-      const signatureResponse = await signPersonalMessage(challenge, wallet, provider);
+      const signatureResponse = await signPersonalMessage(challenge, provider, wallet);


had to switch the order of the arguments here as signPersonalMessage no longer has an optional provider but still can have an optional wallet arg

jinchung · 2024-10-15T16:33:36Z

          screen: SCREEN_FOR_REQUEST_SOURCE[source],
          operation: TimeToSignOperation.SignTransaction,
-        })(message, existingWallet);
+        })(message, provider, existingWallet);


had to switch the order of the arguments for both signPersonalMessage and signTypedDataMessage as they no longer have an optional provider but still can have an optional wallet arg

jinchung · 2024-10-15T18:23:10Z

-    const initProvider = async () => {
-      let p;
-      if (chainId === ChainId.mainnet) {
-        p = await getFlashbotsProvider();


this hook was only used in the SignTransactionSheet for WalletConnect and should not be needing to use the flashbots provider for this flow; moved the fetchNativeAsset logic (lines 27) into SignTransactionSheet itself

jinchung · 2024-10-15T18:23:50Z

        return;
      } else if (!isSigningMethod(payload.method)) {
-        sendRpcCall(payload)
+        const provider = getProvider({ chainId: ChainId.mainnet });


always using ChainId.mainnet is technically not correct but we will be removing this file shortly and it is a no-op to what it was using previously

jinchung · 2024-10-15T18:39:45Z

- * @return The corresponding `TransactionResponse`, or `null` if one could not
- * be found.
- */
-export const getTransaction = async (hash: string): Promise<TransactionResponse | null> => web3Provider?.getTransaction(hash) ?? null;


these 2 functions (getTransaction and getTransactionCount`) were just unused functions

jinchung · 2024-10-15T18:41:17Z

    method: string;
    params: unknown[];
  },
-  provider: StaticJsonRpcProvider | null = null


in this file, most of the changes are related to removing the optional nature for provider in the args - now it is required to provide a provider so take a look at the different places that use these functions to make sure they pass in a valid provider

jinchung · 2024-10-15T18:57:43Z

  address?: EthereumAddress;
  showErrorIfNotLoaded?: boolean;
-  provider?: Provider;
+  provider: Provider;


a lot of changes in this file are also related to making provider arg non-optional; please pay attention to where these functions are being called and that they're passing in non-null provider objects

greg-schrammel · 2024-10-16T18:44:37Z

-    const currentChainId = await getChainId();
-    web3SetHttpProvider(currentChainId);
-    saveChainId(currentChainId);


why was this here?

when we first introduced this remote config logic, we needed to keep the legacy web3Provider object in sync - now we are just relying on the backend networks endpoint for the provider info

benisgold

just requesting changes bc of my first comment.

as an aside, i think it's unnecessary to pass in provider as a param in many places. why do components that are not directly using the provider need to have any knowledge of it? it would make more sense/be more readable to just pass in chainId (if needed, often times this can be extracted from other params such as tx payload), and call getProvider at the lowest level possible.

brunobar79 · 2024-10-16T19:46:34Z

Launch in simulator or device for f3334eb

greg-schrammel

approved since what I noticed ben already commented

brunobar79 · 2024-10-17T17:14:54Z

Launch in simulator or device for afec91f

ibrahimtaveras00

All looks well with the exception of wallet connect and dapp browser. I can sign txn's but I cannot send. When I tap the confirm button, nothing happens. Cancel does work.

iOS tested on = 1.9.42 (54)
Android tested on release.apk

This branch:
https://github.com/user-attachments/assets/3ccc8f19-56e1-4695-a782-7ae22fc9706b

Compared to prod:
https://github.com/user-attachments/assets/0b163337-ddb0-4d29-96d9-dd7273ed2e9b

Steps to reproduce:

navigate to our dapp via Wallet connect and our in-app dapp browser = https://rainbowkit-example.vercel.app/
Connect your wallet
Once connected to wallet & network, tap send transaction
attempt to confirm

…ndler

…ider

…t in SignTransactionSheet

ibrahimtaveras00

Fix looks good, QA Passed 👍🏽

jinchung commented Oct 15, 2024

View reviewed changes

jinchung force-pushed the @jin/web3provider branch from d4a2fd1 to 4ff12c6 Compare October 15, 2024 19:43

jinchung requested review from benisgold, greg-schrammel and ibrahimtaveras00 October 16, 2024 18:17

jinchung marked this pull request as ready for review October 16, 2024 18:18

greg-schrammel reviewed Oct 16, 2024

View reviewed changes

benisgold suggested changes Oct 16, 2024

View reviewed changes

Comment thread src/components/toasts/OfflineToast.js Outdated

Comment thread src/screens/SignTransactionSheet.tsx Outdated

greg-schrammel approved these changes Oct 17, 2024

View reviewed changes

jinchung requested a review from benisgold October 17, 2024 16:06

benisgold approved these changes Oct 17, 2024

View reviewed changes

jinchung force-pushed the @jin/web3provider branch from 021618d to c1cde7c Compare October 17, 2024 16:13

ibrahimtaveras00 requested changes Oct 18, 2024

View reviewed changes

jinchung force-pushed the @jin/web3provider branch from c1cde7c to e120c16 Compare October 18, 2024 22:31

jinchung requested a review from ibrahimtaveras00 October 18, 2024 22:31

jinchung added 5 commits October 21, 2024 09:44

Remove usage of web3Provider from OfflineToast

f22cb7c

Make useProviderSetup always have a non-null provider as default

18c62db

Remove direct web3Provider usage in SendSheet

ef15cf8

Remove unnecessary web3SetHttpProvider usage in remoteConfig fetch query

b151f45

Remove usage of web3SetHttpProvider in redux settings

77d5b61

jinchung added 12 commits October 21, 2024 09:44

Remove web3Provider direct usage for estimating gas limit

87fb779

Remove direct usage of web3Provider in estimateGasWithPadding web3 ha…

a981c87

…ndler

Remove web3SetHttpProvider function

fe609c7

Remove unused web3 handler function for getTransactionCount

48681f9

Ensure web3 handler function estimateGasLimit is always passed a prov…

06dbcec

…ider

Remove unused getTransaction web3 handler

a514501

Remove direct use of web3Provider in sendRpcCall web3 handler

5e76e36

Remove web3Provider from web3 handlers

92940db

Remove web3Provider direct usage from model wallet

12e6149

Remove useProviderSetup and move native asset selection into useEffec…

c0c6dda

…t in SignTransactionSheet

Fix: init useConnectedToHardhatStore

cbff181

Use getNetworkNativeAsset in SignTransactionSheet

5ddb019

jinchung force-pushed the @jin/web3provider branch from e120c16 to 5ddb019 Compare October 21, 2024 13:44

ibrahimtaveras00 approved these changes Oct 21, 2024

View reviewed changes

jinchung merged commit 95df799 into develop Oct 22, 2024

jinchung deleted the @jin/web3provider branch October 22, 2024 12:36

Conversation

jinchung commented Oct 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed (plus any additional context for devs)

Screen recordings / screenshots

What to test

Uh oh!

linear Bot commented Oct 13, 2024

Uh oh!

jinchung Oct 15, 2024

Choose a reason for hiding this comment

Uh oh!

jinchung Oct 15, 2024

Choose a reason for hiding this comment

Uh oh!

jinchung Oct 15, 2024

Choose a reason for hiding this comment

Uh oh!

jinchung Oct 15, 2024

Choose a reason for hiding this comment

Uh oh!

jinchung Oct 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jinchung Oct 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jinchung Oct 15, 2024

Choose a reason for hiding this comment

Uh oh!

jinchung Oct 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

greg-schrammel Oct 16, 2024

Choose a reason for hiding this comment

Uh oh!

jinchung Oct 17, 2024

Choose a reason for hiding this comment

Uh oh!

benisgold left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

brunobar79 commented Oct 16, 2024

Uh oh!

greg-schrammel left a comment

Choose a reason for hiding this comment

Uh oh!

brunobar79 commented Oct 17, 2024

Uh oh!

ibrahimtaveras00 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jinchung commented Oct 13, 2024 •

edited

Loading

jinchung Oct 15, 2024 •

edited

Loading

jinchung Oct 15, 2024 •

edited

Loading

jinchung Oct 15, 2024 •

edited

Loading

ibrahimtaveras00 left a comment •

edited

Loading