Subtract hidden assets from wallet balance #6205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
changed the title
walmat
commented
Oct 16, 2024
benisgold
reviewed
Oct 16, 2024
benisgold
approved these changes
Oct 16, 2024
…nce in the wallet data instead of elsewhere
walmat
requested review from
greg-schrammel and
derHowie
and removed request for
christianbaroni and
estebanmino
greg-schrammel
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1939
Fixes APP-1940
Fixes #6079
Parent issue
Fixes APP-1938
What changed (plus any additional context for devs)
Reading through the commits is probably a good way to understand what has changed, but essentially
userAssetsStorestored per wallet addressuseWalletsHiddenBalances.tswhich subscribes to the Zustand store and updates those balance when an asset hidden state changes or when an asset price changes.Screen recordings / screenshots
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-10-16.at.13.16.09.mp4
What to test
Migrate accounts with previously hidden tokens and make sure they remain hidden
Test hiding new assets, unhiding old assets, etc.