Fix broken context menus #6209
Merged
Fix broken context menus #6209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
commented
Oct 17, 2024
| const handlePressButton = useCallback(() => { | ||
| convertAssetAndNavigate(availableChainIds[0]); | ||
| }, [availableChainIds, convertAssetAndNavigate]); | ||
|
|
||
| const networkMenuItems = supportedSwapChainIds | ||
| .filter(chainId => chainId !== ChainId.mainnet) | ||
| .filter(chainId => chainId !== ChainId.mainnet && availableChainIds.includes(chainId)) |
There was a problem hiding this comment.
we also weren't filtering out non-available chainIds anymore which is fixed now
ibrahimtaveras00
approved these changes
Oct 18, 2024
greg-schrammel
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed (plus any additional context for devs)
During our network expansion, these
actionKeysgot switched from strings to numbers and that broke the context menus. Also the chain images were broken, so those are now fixed.Screen recordings / screenshots
What to test