Remove WC v1 #6214

jinchung · 2024-10-19T16:16:13Z

Fixes APP-1585

What changed (plus any additional context for devs)

Remove WalletConnect v1 (redux/walletconnect as well as entrypoints using WC v1)
Remove requests redux (redux/requests) which was being used by both WC v1 and v2 and replace it with a new store (state/walletConnectRequests)
Removed localstorage for WC requests
We are choosing to ignore migration from redux/localstorage to the new store
Follow up ticket created: alerting the user if they are using a WC v1 request

Screen recordings / screenshots

RPReplay_Final1729624897.MP4

What to test

Test WC flows (message signing, transactions, connections) that they work as expected
Test that requests still show up in the transaction list as expected and behave as expected when you interact with them

linear · 2024-10-19T16:17:06Z

APP-1585 Rip out walletconnect v1

jinchung · 2024-10-22T16:46:55Z

src/App.tsx

@@ -5,7 +5,6 @@ import { AppRegistry, Dimensions, LogBox, StyleSheet, View } from 'react-native'
 import { Toaster } from 'sonner-native';
 import { MobileWalletProtocolProvider } from '@coinbase/mobile-wallet-protocol-host';
 import { DeeplinkHandler } from '@/components/DeeplinkHandler';
-import { AppStateChangeHandler } from '@/components/AppStateChangeHandler';


removing AppStateChangeHandler as it was being used only for WC v1 subscription when coming back from background

jinchung · 2024-10-22T16:49:01Z

src/components/AppStateChangeHandler.tsx

-
-  const handleAppStateChange = useCallback(
-    (nextAppState: AppStateStatus) => {
-      if (appState === 'background' && nextAppState === 'active') {


no longer needed as this was for loading WC v1 when coming back from background app state

jinchung · 2024-10-22T16:51:04Z

src/components/qrcode-scanner/ConnectedDapps.tsx

-import rainbowIconCircle from '@/assets/rainbow-icon-circle.png';
-import { Source } from 'react-native-fast-image';
-
-function ConnectedDapps() {


this component was unused; was replaced with ConnectedDappsSheet a while ago

jinchung · 2024-10-22T16:51:55Z

src/components/walletconnect-list/WalletConnectList.js

-
-const renderItem = ({ item }) => <WalletConnectListItem {...item} />;
-
-export default function WalletConnectList({ onLayout, ...props }) {


unused component

jinchung · 2024-10-22T17:00:06Z

src/components/walletconnect-list/WalletConnectListItem.js

-
-const columnStyle = padding.object(0, 10, 0, 12);
-
-export default function WalletConnectListItem({ account, chainId, dappIcon, dappName, dappUrl }) {


was used for the V1 flow in ConnectedDappsSheet which is no longer needed

jinchung · 2024-10-22T17:32:59Z

src/hooks/useTransactionConfirmation.ts

-import { removeRequest } from '../redux/requests';
-import { walletConnectSendStatus } from '../redux/walletconnect';
-
-export default function useTransactionConfirmation() {


this was an unused hook

jinchung · 2024-10-22T18:58:36Z

src/state/walletConnectRequests/index.ts

+  [requestId: number]: WalletconnectRequestData;
+}
+
+export interface WalletConnectRequestsState {


new store that replaces redux/requests and exposes the same methods for adding a request, removing a request, and getting a sorted list of the WC requests to display

jinchung · 2024-10-22T19:00:37Z

src/walletConnect/index.tsx

@@ -752,21 +752,9 @@ export async function onSessionRequest(event: SignClientTypes.EventArguments['se
      },
    };

-    const { requests: pendingRequests } = store.getState().requests;


for the WC v2 flow, we used to directly update the redux/requests redux state as well as localstorage - now we use the new requests store

jinchung · 2024-10-22T19:01:06Z

src/walletConnect/types.ts

+/**
+ * Display details loaded for a request.
+ */
+interface RequestDisplayDetails {


moved some of the types from the redux/requests and redux/walletconnect over to this file instead

jinchung · 2024-10-22T19:02:17Z

src/notifications/NotificationsHandler.tsx

-    const topic = remoteMessage?.data?.topic;
-
-    setTimeout(() => {
-      const requests = dispatch(requestsForTopic(topic as string));


not sure why it ended up like this, but this function doesn't really do anything other than fetch requests

ibrahimtaveras00

Looks good on both OS's and also did a sanity check on dapp browser to make sure we're good. QA Passed 👍🏽

src/components/asset-list/RecyclerAssetList2/index.tsx

greg-schrammel

didn't test but the code is good 🫶

…tate change

…address

…uestCoinRow

jinchung changed the title ~~@jin/rip wc v1~~ Remove WC v1 Oct 19, 2024

jinchung force-pushed the @jin/rip-wc-v1 branch 4 times, most recently from 381eb59 to 7d0f658 Compare October 22, 2024 16:37

jinchung requested a review from ibrahimtaveras00 October 22, 2024 16:39

jinchung commented Oct 22, 2024

View reviewed changes

jinchung force-pushed the @jin/rip-wc-v1 branch from 7d0f658 to 15e58db Compare October 22, 2024 17:18

jinchung commented Oct 22, 2024

View reviewed changes

jinchung force-pushed the @jin/rip-wc-v1 branch from 15e58db to 7ffa4e8 Compare October 22, 2024 19:07

jinchung requested review from greg-schrammel and derHowie October 22, 2024 19:23

jinchung marked this pull request as ready for review October 22, 2024 19:23

ibrahimtaveras00 approved these changes Oct 23, 2024

View reviewed changes

derHowie approved these changes Oct 24, 2024

View reviewed changes

greg-schrammel reviewed Oct 24, 2024

View reviewed changes

src/components/asset-list/RecyclerAssetList2/index.tsx Outdated Show resolved Hide resolved

greg-schrammel approved these changes Oct 24, 2024

View reviewed changes

jinchung added 4 commits October 25, 2024 08:29

Remove handling of WC v1 deeplinks

c10dbf8

Remove AppStateChangeHandler which was just refreshing WC v1 on app s…

6c7ee91

…tate change

Remove WC v1 load state in refresh account data

c720e1e

Remove WC v1 load state from load account data hook

b4b821e

jinchung added 27 commits October 25, 2024 08:29

Remove unused useTransactionConfirmation hook

0da3012

Move WC related types to walletConnect/types from redux

92c74aa

Remove use of useWalletConnectConnections hook for WC v1

5131fd3

Remove use of redux walletconnect in requestNavigationHandlers

613ba2c

Remove WC v1 handle wallet notif logic

25c0de5

Remove removeRequest function usage

3be44fb

Remove walletconnect redux

2462687

Remove requests redux reset in init wallet

d6ceb76

Remove redux requests load state in load account data

2496913

Move some request types to walletConnect types

a792b2f

Use WC types that were moved to walletConnect types in requestNavHandler

19838bc

Move out types from requests to walletConnect

2164b25

Remove requests redux

a6b3ea3

Remove useRequests hook and replace with new wc requests store

9db31e8

Update walletConnect v2 to use new requests store

d884033

Add support for removing requests in new wc requests store

0a6609e

Update RequestCoinRow to use remove request from new WC requests store

6ba4712

Fixup: add WC request

519b5d4

Fixup: remove wc request

a22057e

Fixup: update usage of addNewWalletConnectRequest to exclude account …

95049fc

…address

Update usage of removeWalletConnectRequest from walletConnect and Req…

da4b235

…uestCoinRow

Use new remove WC requests in requestNavigationHandlers

0552f11

Add sorted WC requests method on store

f3799a5

Remove localstorage for wc requests

f47b53e

Update comment for wc deeplink handler

326c170

Remove unused sendRpcCall

a7c7d9f

Remove unused WC active sessions dep

28b0e37

jinchung force-pushed the @jin/rip-wc-v1 branch from 2ea0f15 to 28b0e37 Compare October 25, 2024 12:29

jinchung merged commit 0d3f6b5 into develop Oct 25, 2024
7 of 8 checks passed

jinchung deleted the @jin/rip-wc-v1 branch October 25, 2024 13:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove WC v1 #6214

Remove WC v1 #6214

jinchung commented Oct 19, 2024 •

edited

Loading

linear bot commented Oct 19, 2024

jinchung Oct 22, 2024

jinchung Oct 22, 2024

jinchung Oct 22, 2024 •

edited

Loading

jinchung Oct 22, 2024

jinchung Oct 22, 2024

jinchung Oct 22, 2024

jinchung Oct 22, 2024

jinchung Oct 22, 2024

jinchung Oct 22, 2024

jinchung Oct 22, 2024

ibrahimtaveras00 left a comment

greg-schrammel left a comment


		const renderItem = ({ item }) => <WalletConnectListItem {...item} />;

		export default function WalletConnectList({ onLayout, ...props }) {


		const columnStyle = padding.object(0, 10, 0, 12);

		export default function WalletConnectListItem({ account, chainId, dappIcon, dappName, dappUrl }) {

Remove WC v1 #6214

Remove WC v1 #6214

Conversation

jinchung commented Oct 19, 2024 • edited Loading

What changed (plus any additional context for devs)

Screen recordings / screenshots

What to test

linear bot commented Oct 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jinchung Oct 22, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

greg-schrammel left a comment

Choose a reason for hiding this comment

jinchung commented Oct 19, 2024 •

edited

Loading

jinchung Oct 22, 2024 •

edited

Loading