Remove chain ID from notifs payload as it is no longer needed #6223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
approved these changes
Oct 22, 2024
derHowie
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-985
Backend changes have fixed APP-985; this PR itself is a no-op, it only reduces the payload we send to the backend for notifications subscription.
What changed (plus any additional context for devs)
Previously, we would send a notification subscription for each wallet on each chain. Now, the backend will handle managing the supported chains, so we only need to send a subscription for each wallet.
Screen recordings / screenshots
TODO: will update once build completes
What to test
Confirm that subscribing and unsubscribing to notifications still behaves as expected (there should be no change.)