Fix reanimated crash #6227
Merged
Fix reanimated crash #6227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianbaroni
approved these changes
Oct 24, 2024
ibrahimtaveras00
approved these changes
Oct 24, 2024
…ix-reanimated-crash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1916
What changed (plus any additional context for devs)
whitelisting text as native prop was causing a few runtime crashes that are hard to reproduce but there's a bunch of reports on sentry. After chatting with @christianbaroni he suggested we disable it.
https://sentry.io/organizations/rainbow-me/issues/5961374042/events/b5e18c03728340b9aa2e32b8887e4421/
Screen recordings / screenshots
No
What to test
make sure it doesn't break the animated inputs that use it, eg dapp browser input / expanded state chart % change label when pressing the chart