Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused env configs #6254

Merged
merged 12 commits into from
Nov 4, 2024
Merged

Remove unused env configs #6254

merged 12 commits into from
Nov 4, 2024

Conversation

jinchung
Copy link
Member

@jinchung jinchung commented Nov 4, 2024

Fixes APP-1994

What changed (plus any additional context for devs)

Cleaned up a bunch of unused env configs.
Many of the RPC configs are now handled by the backend networks endpoint instead.
Corresponds with PR: https://github.com/rainbow-me/rainbow-env/pull/72

Screen recordings / screenshots

Screenshot 2024-11-04 at 3 06 32 PM

What to test

  • Wallet data behaves as expected on ios and android
  • Add cash flow behaves as expected on ios and android

Copy link

linear bot commented Nov 4, 2024

@brunobar79
Copy link
Member

Launch in simulator or device for f7c361d

@jinchung jinchung merged commit 7f26695 into develop Nov 4, 2024
8 checks passed
@jinchung jinchung deleted the @jin/env-config branch November 4, 2024 21:37
@BrodyHughes BrodyHughes mentioned this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants