Fix swaps crashing on tokens with 0 decimals
#6263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
changed the title
0 decimals.0 decimals
walmat
commented
Nov 12, 2024
Comment on lines
+223
to
224
| minimumFractionDigits: Math.min(2, dec), | ||
| maximumFractionDigits: dec, |
There was a problem hiding this comment.
this was breaking on 0 decimal assets so we need to min it.
walmat
requested review from
greg-schrammel,
benisgold and
ibrahimtaveras00
and removed request for
greg-schrammel
Comment on lines
494
to
495
| const inputDecimals = inputAsset?.networks[inputAsset.chainId]?.decimals || inputAsset?.decimals; | ||
| const outputDecimals = outputAsset?.networks[outputAsset.chainId]?.decimals || outputAsset?.decimals; |
There was a problem hiding this comment.
I think we should do
Suggested change
| const inputDecimals = inputAsset?.networks[inputAsset.chainId]?.decimals || inputAsset?.decimals; | |
| const outputDecimals = outputAsset?.networks[outputAsset.chainId]?.decimals || outputAsset?.decimals; | |
| const inputDecimals = inputAsset?.networks[inputAsset.chainId]?.decimals ?? inputAsset?.decimals; | |
| const outputDecimals = outputAsset?.networks[outputAsset.chainId]?.decimals ?? outputAsset?.decimals; |
maybe don't have to check if is a number by using ??
greg-schrammel
approved these changes
Nov 12, 2024
benisgold
approved these changes
Nov 12, 2024
ibrahimtaveras00
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-2024
What changed (plus any additional context for devs)
Tokens with
0decimals was forcing our fallback case of18decimals. This was causing our swaps flow to underflow due to adjusting tokens that shouldn't be 18 decimals.I've adjusted most of the places in our app that we use a default of
18decimals to only do so if the decimals isn't a number value (akatypeof decimals !== 'number').Screen recordings / screenshots
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-11-12.at.13.40.09.mp4
What to test