Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix position of headings when following links #163

Open
MattMS opened this issue Dec 27, 2016 · 3 comments
Open

Fix position of headings when following links #163

MattMS opened this issue Dec 27, 2016 · 3 comments

Comments

@MattMS
Copy link
Member

MattMS commented Dec 27, 2016

The navbar will overlap the content when following a link such as http://ramdajs.com/#partial-builds

This was mentioned by @davidchambers in ramda/ramda#2025.

@MattMS
Copy link
Member Author

MattMS commented Dec 27, 2016

We cannot use the hack fix from #161 because the HTML is generated from Markdown.

Using the body {padding-top: @navbar-height;} recommended fix does not seem to work either.

@davidchambers
Copy link
Member

What I've done in the past is given each heading top padding and negative top margin.

@MattMS
Copy link
Member Author

MattMS commented Dec 30, 2016

That seems to work, but replacing the existing top margin and padding changes the layout.
So margins that would normally collapse together are no longer able to.

I've got the code written and working so I'll open a PR for further comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants