Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old files #176

Open
MattMS opened this issue May 13, 2017 · 6 comments
Open

Remove old files #176

MattMS opened this issue May 13, 2017 · 6 comments

Comments

@MattMS
Copy link
Member

MattMS commented May 13, 2017

There are a few files in the repo that I don't think are used any more, so we could probably remove them.

  • index.html.handlebars
  • releases.html.handlebars

If #175 is merged:

  • repl/index.html.handlebars
  • repl/css/page.css

Possibly these too?

  • repl/.babelrc
  • repl/.gitignore
  • repl/npm-shrinkwrap.json
  • repl/package.json
  • repl/README.md
  • repl/lib/*

Possibly controversial:

  • Makefile
@buzzdecafe
Copy link
Member

#175 is merged. Less is certainly more. If you find the Makefile is in the way and npm is sufficient to build the site, I would not object to removing the Makefile.

@MattMS
Copy link
Member Author

MattMS commented May 14, 2017

I don't find it in the way, I think it's quite out of date though, so I really wouldn't recommend using it.
I think all the operations are covered by other scripts, so it doesn't seem necessary.
I could look into updating the Makefile to include all the latest scripts if people would really like to keep it though.

@buzzdecafe
Copy link
Member

I think all the operations are covered by other scripts...

If this is so, I have no objection to removing the Makefile. I'd much rather have one way to this.

@kedashoe
Copy link
Contributor

Agreed with @buzzdecafe

@Klortho
Copy link

Klortho commented Apr 15, 2018

+1, as I just wasted an hour trying to get make to work.

@customcommander
Copy link
Member

customcommander commented Jan 19, 2022

I'm a big fan of Make but I agree that as it is the Makefile might as well just be a simple shell script.

I recently started cleaning things up. I wanted to keep the Makefile to the bare minimum so that we know exactly what needs to be migrated as a shell script. (Will also put an NPM script)

There are still some files that need to be deleted so that list is still useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants