Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the documentation "Expand parameters" supposed to be JSDoc? #268

Open
kee-oth opened this issue Feb 21, 2022 · 5 comments
Open

Is the documentation "Expand parameters" supposed to be JSDoc? #268

kee-oth opened this issue Feb 21, 2022 · 5 comments
Assignees

Comments

@kee-oth
Copy link

kee-oth commented Feb 21, 2022

Hi!

In the Ramda docs, clicking on "Expand parameters" gives you a sort of JSDoc style of documentation but it looks incomplete.

add, for example, only shows parameter names but not their types. You can see in the HTML on the page that the span.type element is empty.

https://ramdajs.com/docs/#add

a
b
Returns Number

The HTML

<li class="list-group-item">
  <span class="type"></span>
  <span class="name">a</span>
  <span class="description"></span>
</li>

Is this intentional? If it is, is the intention that developers would look at the Hindley-Milner representation and the JSDoc style representation and put them together in their head to get a full picture?

@CrossEye
Copy link
Member

No, I think that's a bug. I'm pretty sure that used to work. The descriptions from the source code comment block as well as the names are showing up. (There just happen to be no descriptions for add's parameters.) But the type should also show. I'm not sure when this broke, but we should fix it. I don't know when it broke, as I never look at those, preferring the HM-annotations. But we'll try to get to it soon.

@kee-oth
Copy link
Author

kee-oth commented Feb 22, 2022

Gotcha, thanks so much for the response!

@kee-oth kee-oth closed this as completed Feb 22, 2022
@kee-oth
Copy link
Author

kee-oth commented Feb 22, 2022

Commenting to re-open from accidental closing 🤦‍♂️

@kee-oth kee-oth reopened this Feb 22, 2022
@customcommander customcommander transferred this issue from ramda/ramda Feb 22, 2022
@customcommander customcommander self-assigned this Feb 22, 2022
@customcommander
Copy link
Member

I don't recall having touched that specific part of the doc generator but it's not impossible that I broke it when I last updated the docs. I'll have a look. Thanks for the report.

@CrossEye
Copy link
Member

There are several other things that broke in the most recent docs/repl changes, and several before that. I will try to collect a list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants