Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing bug incorrect distortion coeff in fisheye #69

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Fixing bug incorrect distortion coeff in fisheye #69

merged 1 commit into from
Mar 27, 2024

Conversation

BAILOOL
Copy link
Collaborator

@BAILOOL BAILOOL commented Mar 24, 2024 •
edited
Loading

Closes #68, Closes #66

@BAILOOL BAILOOL added the bug Something isn't working label Mar 24, 2024
@BAILOOL BAILOOL requested a review from rameau-fr March 24, 2024 08:17
@BAILOOL BAILOOL self-assigned this Mar 24, 2024
@github-actions GitHub Actions
Copy link

LCOV of commit ceffec5 during CI #124

Summary coverage rate:
  lines......: 77.7% (2744 of 3532 lines)
  functions..: 88.0% (241 of 274 functions)
  branches...: no data found

Files changed coverage rate: n/a

@BAILOOL
Copy link
Collaborator Author

BAILOOL commented Mar 26, 2024

mean reprojection error
before fix 1.52138
after fix 1.36369

@BAILOOL BAILOOL merged commit 62d0587 into master Mar 27, 2024
7 checks passed
@BAILOOL BAILOOL deleted the feature/fisheye-distortion-coeffs-order-bug branch March 27, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rameau-fr rameau-fr rameau-fr approved these changes

Assignees

@BAILOOL BAILOOL

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test not good in my dataset about fish images Fisheye distortion coefficient format
2 participants
@BAILOOL @rameau-fr