Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include an option to draw values in canvas. #3

Open
ramesaliyev opened this issue Oct 7, 2018 · 4 comments
Open

Include an option to draw values in canvas. #3

ramesaliyev opened this issue Oct 7, 2018 · 4 comments
Labels
enhancement New feature or request

Comments

@ramesaliyev
Copy link
Owner

ramesaliyev commented Oct 7, 2018

Like discussed in here and demonstrated in here add a option to show values of lines in diagram like bazooka2th did in his/her work.

@ramesaliyev ramesaliyev added the enhancement New feature or request label Oct 7, 2018
@gokaygurcan
Copy link

untitled720

I tried this, and didn't like the results.

@ramesaliyev
Copy link
Owner Author

Hi, thank you for taking care of this! Actually this was the exact result i was hoping to achieve. It seems a little bit crowded of course, (is this the reason you didnt like it?) but this will be optional and defaultly disabled. Also users can use this with short names, that would be more clear.

@gokaygurcan
Copy link

Hi again,
totally forgot this one. anyway. i didn't like it because in the given example, everything is static until you start to move stuff. but here, it moves constantly, so it requires to calculate changes lots of times in every second and to update the canvas element. i saw some discrepancies between the values next to sin/cos/tan/etc. and values on the right pane.

but still, i can wrap it up and create a pull request. then we can talk about possible improvements if you want.

best,
G.

@ramesaliyev
Copy link
Owner Author

Hi! Sorry for late answer, i was really crowded. Actually i think its good enough right now, and it would be good if you wrap it up because i'm planning changes which may introduce breaking changes for improvements which done in current codebase.

One of improvement that i'm planning to do is moving all calculations to another place. So this will solve discrepancies that you mentioned i think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants