Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts: Add guestagent and trivy into wsl-distro tarball instead of installing at runtime #7145

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mook-as
Copy link
Contributor

@mook-as mook-as commented Jul 4, 2024

Fixes #7137.

  • Convert the go utility building to Dependencys, and implement crude dependency tracking so that they can depend on each other.
    • Note that GoDependency can take an array as the first argument, so new GoDependency(['networking', 'cmd', 'network']) is valid.
  • Embed the guest agent and trivy into the WSL distro. Note that we do not change trivy for Lima-based platforms for now.
  • Mark some files as not needing to be installed (this was from when I was ignoring specific files; I've changed to put the files in a new staging directory instead so not packaging them is easier).

This allows dependencies to depend on other dependencies, including across
platforms; we intend to allow WSLDistro to depend on Linux bits.

Signed-off-by: Mark Yen <[email protected]>
This makes the go utilities act like dependencies, so we can use them as
dependencies of other dependencies.

Signed-off-by: Mark Yen <[email protected]>
This embeds rancher-desktop-guestagent as part of the WSL distro on post-
install, so that we do not need to copy it into the VM at run time.

Signed-off-by: Mark Yen <[email protected]>
- We don't actually support localization
- There is no point in including source maps, we don't ship the sources
- Support merging file lists

Signed-off-by: Mark Yen <[email protected]>
@gunamata gunamata requested a review from Nino-K July 5, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scripts: Add guestagent and trivy into wsl-distro tarball instead of installing at runtime
1 participant