fix: Correct genericoidc provider implementation and tests #1691
+11
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@matttrach , @raulcabello , please, take a look. |
raulcabello
approved these changes
Oct 23, 2025
Contributor
raulcabello
left a comment
raulcabello
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the fix!
Contributor
Author
|
@matttrach , hello, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Follow-up fixes for #51059
Problem
The initial implementation of the genericoidc auth provider incorrectly used the OIDCConfig struct instead of the GenericOIDCConfig struct. This caused a runtime panic during the read operation due to a type assertion failure.
Solution
This PR provides critical corrections to the rancher2_auth_config_generic_oidc resource to make it fully functional and robust.