Skip to content

Commit 61bf613

Browse files
Merge pull request #426 from range-of-motion/replace-usage-of-native-date-function-in-spaceinvite-model
Replace usage of native date function in SpaceInvite model
2 parents 90057dc + 01bf6ef commit 61bf613

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

app/Models/SpaceInvite.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,11 @@ protected function status(): Attribute
4747
}
4848

4949
if ($this->accepted === true) {
50-
return 'Accepted (' . date('d-m', strtotime($this->updated_at)) . ')';
50+
return 'Accepted (' . $this->updated_at->format('d-m') . ')';
5151
}
5252

5353
if ($this->accepted === false) {
54-
return 'Denied (' . date('d-m', strtotime($this->updated_at)) . ')';
54+
return 'Denied (' . $this->updated_at->format('d-m') . ')';
5555
}
5656

5757
return 'Unknown';

tests/Unit/Models/SpaceInviteTest.php

+5-2
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
namespace Tests\Unit\Models;
44

55
use App\Models\SpaceInvite;
6+
use Carbon\Carbon;
67
use Tests\TestCase;
78

89
class SpaceInviteTest extends TestCase
@@ -19,15 +20,17 @@ public function testStatusAttribute(): void
1920
$acceptedSpaceInvite = SpaceInvite::factory()
2021
->make([
2122
'accepted' => true,
23+
'updated_at' => Carbon::parse('2021-02-14'),
2224
]);
2325

24-
$this->assertStringStartsWith('Accepted', $acceptedSpaceInvite->status);
26+
$this->assertEquals('Accepted (14-02)', $acceptedSpaceInvite->status);
2527

2628
$deniedSpaceInvite = SpaceInvite::factory()
2729
->make([
2830
'accepted' => false,
31+
'updated_at' => Carbon::parse('2021-02-14'),
2932
]);
3033

31-
$this->assertStringStartsWith('Denied', $deniedSpaceInvite->status);
34+
$this->assertEquals('Denied (14-02)', $deniedSpaceInvite->status);
3235
}
3336
}

0 commit comments

Comments
 (0)