Skip to content

feat: add bitcoin signer for phantom on hub #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

RyukTheCoder
Copy link
Collaborator

@RyukTheCoder RyukTheCoder commented Dec 24, 2024

Summary

Added connect and sign transaction on Bitcoin using Phantom Wallet.

How did you test this change?

This change can be tested by connecting, switching account and signing transactions on Bitcoin using Phantom wallet.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Implemented a user interface (UI) change, referencing our Figma design to ensure pixel-perfect precision.

@RyukTheCoder RyukTheCoder force-pushed the feat/add-btc-signer-for-phantom-on-hub branch 3 times, most recently from 6ed6089 to 89abf1f Compare February 4, 2025 12:06
@RyukTheCoder RyukTheCoder force-pushed the feat/add-btc-signer-for-phantom-on-hub branch from d822d6d to 89abf1f Compare February 5, 2025 06:47
@RyukTheCoder RyukTheCoder force-pushed the feat/add-btc-signer-for-phantom-on-hub branch from 89abf1f to 985d31b Compare February 5, 2025 10:21
@RyukTheCoder RyukTheCoder changed the title !WIP feat: add bitcoin signer for phantom on hub feat: add bitcoin signer for phantom on hub Feb 5, 2025
@RyukTheCoder
Copy link
Collaborator Author

Also I've added bitcoin change acccount subscriber in 7e95083. Check please.
@yeager-eren

Copy link
Collaborator

@yeager-eren yeager-eren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great integration, thanks for your effort on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants