-
Notifications
You must be signed in to change notification settings - Fork 32
feat: add bitcoin signer for phantom on hub #972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc8854a
to
9e5c1cc
Compare
yeager-eren
reviewed
Jan 27, 2025
6ed6089
to
89abf1f
Compare
d822d6d
to
89abf1f
Compare
89abf1f
to
985d31b
Compare
7 tasks
yeager-eren
requested changes
Feb 11, 2025
3 tasks
985d31b
to
3184ba5
Compare
Also I've added bitcoin change acccount subscriber in 7e95083. Check please. |
yeager-eren
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great integration, thanks for your effort on this.
37a318b
to
071620d
Compare
6230629
to
d4c2762
Compare
fc9829e
to
c4c1468
Compare
c4c1468
to
f8a4fca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added connect and sign transaction on Bitcoin using Phantom Wallet.
How did you test this change?
This change can be tested by connecting, switching account and signing transactions on Bitcoin using Phantom wallet.
Checklist: