Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate useful notebooks to the deployment docs repo #203

Open
18 of 34 tasks
Tracked by #197
jacobtomlinson opened this issue Jan 20, 2023 · 1 comment
Open
18 of 34 tasks
Tracked by #197

Migrate useful notebooks to the deployment docs repo #203

jacobtomlinson opened this issue Jan 20, 2023 · 1 comment
Assignees
Labels
notebook-migration Migrating notebooks to Deployment docs

Comments

@jacobtomlinson
Copy link
Member

jacobtomlinson commented Jan 20, 2023

In rapidsai/deployment#108 I copied a couple of the notebooks from this repo over into the deployment docs so that I had something to work with when updating the Sphinx theme.

As part of #197 we need to migrate the rest of the notebooks in this repo over, but those can be done in separate PRs. Not all notebooks here are in a good state, so we should just focus on migrating the ones which are up to date and confirmed to be working/useful.

My preference would be for each notebook to be placed in its own directory in the source/examples section of the deployment repo with no nesting. The notebook should probably be renamed to notebook.ipynb too so that the URL looks nice.

Any supporting files should be also placed in the directory alongside the notebook. Again ideally without any nested directories unless there is a technical reason why we need to do so.

source/examples
├── index.md
├── rapids-sagemaker-higgs
│   ├── Dockerfile
│   ├── notebook.ipynb
│   └── rapids-higgs.py
└── xgboost-gpu-hpo-job-parallel-k8s
    └── notebook.ipynb

Each notebook also needs to be added to the toctree of the source/examples/index.md file.

Once the notebook has been copied and merged it needs to be removed from this repo and replaced with a link so folks can find them again.

Tasks

  1. 1 of 9
    migrate: no notebook-migration
    jacobtomlinson
  2. 8 of 9
    migrate: yes notebook-migration
    jacobtomlinson
  3. 6 of 9
    migrate: yes notebook-migration
    skirui-source
  4. 0 of 9
    notebook-migration
    mmccarty
  5. 0 of 9
    notebook-migration
  6. 9 of 9
    notebook-migration
    skirui-source
  7. 0 of 9
    notebook-migration
  8. 0 of 9
    notebook-migration
  9. 0 of 9
    notebook-migration
    skirui-source
  10. migrate: yes notebook-migration
    skirui-source
  11. 0 of 9
    notebook-migration
    skirui-source
  12. 0 of 9
    notebook-migration
    skirui-source
  13. 1 of 9
    migrate: yes notebook-migration
  14. 1 of 9
    migrate: no notebook-migration
    jacobtomlinson
  15. 0 of 9
    notebook-migration
  16. 0 of 9
    notebook-migration
  17. 0 of 9
    notebook-migration
  18. 1 of 9
    migrate: no notebook-migration
    jacobtomlinson
  19. 0 of 9
    notebook-migration
  20. 0 of 9
    migrate: no notebook-migration
  21. 0 of 9
    migrate: no notebook-migration
  22. 1 of 9
    migrate: yes notebook-migration
    betatim
  23. 0 of 9
    migrate: yes notebook-migration
  24. 1 of 9
    migrate: no notebook-migration
    jacobtomlinson
  25. 0 of 9
    notebook-migration
  26. 9 of 9
    migrate: yes notebook-migration
    jacobtomlinson
  27. 0 of 9
    notebook-migration
  28. 9 of 9
    migrate: yes notebook-migration
    jacobtomlinson
  29. 0 of 9
    notebook-migration
  30. 0 of 9
    notebook-migration
  31. 2 of 9
    migrate: yes notebook-migration
    jacobtomlinson
  32. 9 of 9
    migrate: yes notebook-migration
    jacobtomlinson
  33. 9 of 9
    migrate: yes notebook-migration
    jacobtomlinson
  34. 0 of 9
    notebook-migration
@jacobtomlinson
Copy link
Member Author

jacobtomlinson commented Jan 31, 2023

Notebook migration guide

We are migrating the notebooks from this repo to the deployment docs. To get started pick any unassigned issue from the tasklist above and assign yourself. Unassigned notebooks with migrate: yes already set are the highest priority.

Decide if notebook should be migrated

For each notebook we need to assess it and decide whether we actually want to migrate it. If the notebook is very out of date or irrelevant to the state of RAPIDS today we shouldn't waste time with it and just let it be archived. Some notebooks are fully up to date (as noted by a link a green tick on the repo README) so definitely should be migrated and have already been marked as such. Others are in the middle.

Use your best judgement and add a migrate: yes or migrate: no label to the issue, if you decide no write a small comment in the issue on why it won't be migrated and then close the issue.

Test if notebook works

Run through the notebook and check that it works and the instructions make sense.

If the notebook needs some attention fix things up and get it into a good state.

Ensure notebook has good title and metadata tags in the first cell

The first cell of each notebook should be markdown and contain a descriptive title and a few sentences about what the notebook does.

This cell should also have cell tags to allow it to be organised by the notebook gallery Sphinx extension.

For example if the notebook is an HPO workflow running on Azure ML and uses XGBoost and cuDF it should have workflows/hpo, cloud/azure/ml, library/xgboost and library/cudf tags.

Remove any deployment instructions and link instead

Many of the notebooks have deployment instructions baked into them. We should remove or at least slim these down and link out to the deployment documentation pages.

For example if a notebook contains instructions on starting a Kubernetes cluster on Google Cloud that should be replaced with a callout to the GKE documentation page.

Copy notebook to deployment docs examples

In the Deployment docs repo create a new directory for the notebook in source/examples and copy the notebook into that directory. The notebook should also be renamed to notebook.ipynb to make the URL neater.

Copy any supporting files to the folder

If the notebook has supporting files such as Python scripts, Dockerfiles or any other config files also copy those into the directory. The notebook gallery Sphinx extension will list these files automatically in the sidebar and link to them on GitHub once they have been merged.

Add notebook to examples toctree

Also update the toctree in source/examples/index.md with the relative path to the notebook.

Make PR to deployment docs repo

Open a new Pull Request for each notebook so we can review them individually. Mark the PR as closing the issue in this repo associated with that notebook.

@jacobtomlinson jacobtomlinson added the notebook-migration Migrating notebooks to Deployment docs label Jan 31, 2023
This was referenced Jan 31, 2023
@skirui-source skirui-source removed their assignment Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook-migration Migrating notebooks to Deployment docs
Projects
None yet
Development

No branches or pull requests

3 participants