Skip to content

Commit c78df5a

Browse files
authored
Merge pull request #1525 from raydouglass/ci-cudatoolkit-dep
[WIP] Add cudatoolkit dependencies to conda packages for community compatibility
2 parents 04f385a + 684eedc commit c78df5a

File tree

6 files changed

+12
-23
lines changed

6 files changed

+12
-23
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,12 +61,12 @@
6161
- PR #1484 Convert GroupBy CFFI to Cython
6262
- PR #1463 Allow and default melt keyword argument var_name to be None
6363
- PR #1486 Parquet Reader: Use device_buffer rather than device_ptr
64+
- PR #1525 Add cudatoolkit conda dependency
6465
- PR #1520 Renamed `src/dataframe` to `src/table` and moved `table.hpp`. Made `types.hpp` to be type declarations only.
6566
- PR #1521 Added `row_bitmask` to compute bitmask for rows of a table. Merged `valids_ops.cu` and `bitmask_ops.cu`
6667
- PR #1553 Overload `hash_row` to avoid using intial hash values. Updated `gdf_hash` to select between overloads
6768
- PR #1559 Add `except +` to all Cython function definitions to catch C++ exceptions properly
6869

69-
7070
## Bug Fixes
7171

7272
- PR #1233 Fix dtypes issue while adding the column to `str` dataframe.

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,11 @@ cuDF can be installed with conda ([miniconda](https://conda.io/miniconda.html),
4949
```bash
5050
# for CUDA 9.2
5151
conda install -c nvidia -c rapidsai -c numba -c conda-forge -c defaults \
52-
cudf=0.6 python=3.6
52+
cudf=0.6 python=3.6 cudatoolkit=9.2
5353

5454
# or, for CUDA 10.0
55-
conda install -c nvidia/label/cuda10.0 -c rapidsai/label/cuda10.0 -c numba \
56-
-c conda-forge -c defaults cudf=0.6 python=3.6
55+
conda install -c nvidia -c rapidsai -c numba -c conda-forge -c defaults \
56+
cudf=0.6 python=3.6 cudatoolkit=10.0
5757
```
5858

5959
We also provide [nightly conda packages](https://anaconda.org/rapidsai-nightly) built from the tip of our latest development branch.

ci/cpu/upload_anaconda.sh

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,7 @@ if [ -z "$MY_UPLOAD_KEY" ]; then
2727
fi
2828

2929
if [ "$UPLOAD_LIBCUDF" == "1" ]; then
30-
if [ "$LABEL_MAIN" == "1" ]; then
31-
LABEL_OPTION="--label main --label cuda${CUDA_REL}"
32-
elif [ "$LABEL_MAIN" == "0" ]; then
33-
LABEL_OPTION="--label dev --label cuda${CUDA_REL}"
34-
else
35-
echo "Unknown label configuration LABEL_MAIN='$LABEL_MAIN'"
36-
exit 1
37-
fi
30+
LABEL_OPTION="--label main --label cuda${CUDA_REL}"
3831
echo "LABEL_OPTION=${LABEL_OPTION}"
3932

4033
test -e ${LIBCUDF_FILE}
@@ -44,16 +37,7 @@ if [ "$UPLOAD_LIBCUDF" == "1" ]; then
4437
fi
4538

4639
if [ "$UPLOAD_CUDF" == "1" ]; then
47-
48-
# Have to label all CUDA versions due to the compatibility to work with any CUDA
49-
if [ "$LABEL_MAIN" == "1" ]; then
50-
LABEL_OPTION="--label main --label cuda9.2 --label cuda10.0"
51-
elif [ "$LABEL_MAIN" == "0" ]; then
52-
LABEL_OPTION="--label dev --label cuda9.2 --label cuda10.0"
53-
else
54-
echo "Unknown label configuration LABEL_MAIN='$LABEL_MAIN'"
55-
exit 1
56-
fi
40+
LABEL_OPTION="--label main --label cuda9.2 --label cuda10.0"
5741
echo "LABEL_OPTION=${LABEL_OPTION}"
5842

5943
test -e ${LIBCUDF_CFFI_FILE}

conda/environments/cudf_dev_cuda10.0.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,5 +25,6 @@ dependencies:
2525
- numpydoc
2626
- ipython
2727
- recommonmark
28+
- cudatoolkit=10.0
2829
- pip:
2930
- sphinx-markdown-tables

conda/environments/cudf_dev_cuda9.2.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,6 @@ dependencies:
2626
- ipython
2727
- recommonmark
2828
- pandoc=<2.0.0
29+
- cudatoolkit=9.2
2930
- pip:
3031
- sphinx-markdown-tables

conda/recipes/libcudf/meta.yaml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
{% set version = environ.get('GIT_DESCRIBE_TAG', '0.0.0.dev').lstrip('v') %}
44
{% set git_revision_count=environ.get('GIT_DESCRIBE_NUMBER', 0) %}
5-
{% set cuda_version='.'.join(environ.get('CUDA_VERSION', 'unknown').split('.')[:2]) %}
5+
{% set cuda_version='.'.join(environ.get('CUDA_VERSION', '9.2').split('.')[:2]) %}
66
package:
77
name: libcudf
88
version: {{ version }}
@@ -27,6 +27,9 @@ requirements:
2727
host:
2828
- librmm 0.7.*
2929
- libnvstrings 0.7.*
30+
- cudatoolkit {{ cuda_version }}.*
31+
run:
32+
- {{ pin_compatible('cudatoolkit', max_pin='x.x') }}
3033

3134
test:
3235
commands:

0 commit comments

Comments
 (0)