Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA]: Spatial Autocorrelation #1137

Open
Intron7 opened this issue May 16, 2023 · 4 comments
Open

[FEA]: Spatial Autocorrelation #1137

Intron7 opened this issue May 16, 2023 · 4 comments
Labels
feature request New feature or request Needs Triage Need team to review and classify

Comments

@Intron7
Copy link

Intron7 commented May 16, 2023

Is this a new feature, an improvement, or a change to existing functionality?

New Feature

How would you describe the priority of this feature request

Low (would be nice)

Please provide a clear description of problem you would like to solve.

I implemented spatial autocorrelation using Moran's I and Geary's C on GPUs for my spatial Transcriptomics. It's up 100 times (using an RTX3090) faster than the CPU implementation from squidgy (using 32 cores). It could be a great expansion of cuSpatial towards GIS functionality.

Describe any alternatives you have considered

GIS, Squidpy

Additional context

Code:
https://github.com/scverse/rapids_singlecell/tree/main/src/rapids_singlecell/squidpy_gpu

benchmark:
https://github.com/scverse/rapids_singlecell/blob/main/notebooks/autocorr_benchmark.ipynb

@Intron7 Intron7 added Needs Triage Need team to review and classify feature request New feature or request labels May 16, 2023
@harrism
Copy link
Member

harrism commented May 17, 2023

Thank you for the feature request and for the example code @Intron7 . Let us know if you are interested in contributing an implementation.

We are a very small team, with a big backlog of feature requests. So any information to help us prioritize would be valuable.

@Intron7
Copy link
Author

Intron7 commented May 17, 2023

I'll try to create a working implementation that fits within the cuSpatial Framework. Are cupy.RawKernels acceptable for the solution?

@harrism
Copy link
Member

harrism commented May 17, 2023

Not normally. Like the rest of cuSpatial, this feature should be implemented in C++ and exposed to Python via Cython bindings.

@Intron7
Copy link
Author

Intron7 commented May 17, 2023

Ok perfect, I'll see what I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request Needs Triage Need team to review and classify
Projects
Status: Todo
Development

No branches or pull requests

2 participants