Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA]: A function to validate geometric data #1140

Open
harrism opened this issue May 17, 2023 · 0 comments
Open

[FEA]: A function to validate geometric data #1140

harrism opened this issue May 17, 2023 · 0 comments
Labels
feature request New feature or request Needs Triage Need team to review and classify

Comments

@harrism
Copy link
Member

harrism commented May 17, 2023

Is this a new feature, an improvement, or a change to existing functionality?

New Feature

How would you describe the priority of this feature request

Medium

Please provide a clear description of problem you would like to solve.

It would be nice to be able to check that a GeoSeries (and at the libcuspatial level, a geometry column) contains valid data. For example if there are unclosed geometries, etc.

This should follow the definitions here: https://postgis.net/docs/using_postgis_dbmanagement.html#OGC_Validity

Also, we should provide GeoSeries APIs/attributes is_valid and is_simple (also possibly is_ring) a la GeoPandas, as well as the equivalent at the libcuspatial C++ level.

We do not introspect data to validate it at construction time or at the point of calling algorithms. This is because doing so is an expense users are not likely willing to pay at all times (especially if their data has been validated already). It is up to the user to validate data, so we should provide APIs to do so.

Describe any alternatives you have considered

Validation on the host using GeoPandas, Shapely or other libraries is possible but the round trip and memory overhead is too expensive.

Not providing validation APIs makes our software potentially harder to use.

Additional context

No response

@harrism harrism added feature request New feature or request Needs Triage Need team to review and classify labels May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request Needs Triage Need team to review and classify
Projects
Status: Todo
Development

No branches or pull requests

1 participant