Add doc for using cuDF & cuSpatial to calculate Haversine Distance #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @taureandyernv ! Can you retarget to 23.10? We cannot open new PRs for 23.08 at burn down. |
isVoid
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Thanks for making the contribution. If only to show case the usage of haversine distance, this is a duplication of the existing haversine section in cuspatial_api_examples.ipynb. However, we certainly need a section to show the joint usage of cudf dataframe and cuspatial APIs and this is a good candidate. My thoughts are to show the canonical use case of:
Separate lon/lat Coordinates in cudf dataframe -> interleave_columns() -> from_points_xy -> API
And
Interleaved coordinate of cupy array -> from_points_xy -> API.
Contributions welcome!
taureandyernv
force-pushed
the
branch-23.08
branch
from
5e2593f
to
f105464
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will add documentation to help users take point data form cuDF and use it with the cuSpatial GeoSeries for calculating haversine distance
Closes #1248
Checklist