Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC]: Remove deprecated geopandas.dataset usage in cuspatial_api_examples.ipynb #1403

Closed
mroeschke opened this issue Jul 8, 2024 · 1 comment · Fixed by #1404
Closed
Labels
doc Documentation

Comments

@mroeschke
Copy link
Contributor

How would you describe the priority of this documentation request

Low (would be nice)

Is this for new documentation, or an update to existing docs?

Update

Describe the incorrect/future/missing documentation

cuspatial_api_examples.ipynb uses the geopandas.dataset API which has been removed in geopandas 1.0.

It would good to either:

  1. Download the shape file(s) used in this notebook.
  2. Rework the notebook without using an external file. (IMO probably preferable)

Once addressed the test_notebooks block in dependencies.yaml introduced in #1400 can removed

If this is a correction, please provide a link to the incorrect documentation. If this is a new documentation request, please link to where you have looked.

No response

@isVoid
Copy link
Contributor

isVoid commented Jul 9, 2024

Thanks - the removal is underway in #1404

@isVoid isVoid linked a pull request Jul 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants