[BUG]: notebooks broken: "cannot access local variable 'execution_time'" #1406
Assignees
Labels
bug
Something isn't working
Comments
|
It turns out that the initial error reported in this issue was a bug in the testing code in But the |
rapids-bot bot
pushed a commit
to rapidsai/docker
that referenced
this issue
Jul 18, 2024
…mit, drop cuspatial notebooks (#690) CI has been failing here for a few weeks, as a result of some failing `cuspatial` notebooks. As described in rapidsai/cuspatial#1406, I observed those notebooks failing like this: ```text cannot access local variable 'execution_time' where it is not associated with a value ``` Turns out that that was coming from the `test_notebooks.py` script in this repo. It calls `return execution_time` unconditionally, even though it's possible for that variable to not exist. This fixes that, and proposes adding a `pre-commit` configuration and corresponding CI job, to help catch such things earlier in the future. This also proposes skipping some `cuspatial` notebooks, to get CI working. I'd hoped to address that in rapidsai/cuspatial#1407, but most `cuspatial` maintainers are busy or unavailable this week. I think we should get CI working here again and deal with the `cuspatial` notebooks as a separate concern. ## Notes for Reviewers Any other changes you see in files here are the result of running `pre-commit run --all-files` (with some manual fixes applied to fix `ruff` warnings). Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Ray Douglass (https://github.com/raydouglass) - https://github.com/jakirkham - AJ Schmidt (https://github.com/ajschmidt8) URL: #690
|
This was fixed in a mix of these PRs:
I've written up the underlying issue that lead to these failures, with reproducible example and more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
24.08
On which installation method(s) does this occur?
Conda
Describe the issue
Several notebooks from this repo are run in the CI for .
The following are currently failing:
cuspatial_api_examples.ipynb(code link)nyc_taxi_years_correlation.ipynb(code link)Both with this eror
(build link)
Minimum reproducible example
See the CI from rapidsai/docker#688.
https://github.com/rapidsai/docker/actions/runs/9962919476/job/27529191373?pr=688
Relevant log output
No response
Environment details
I've observed this across 3 different environment there in
rapidsai/docker's CI.Note that this happens across all jobs there:
(CUDA 11.8, amd64, Python 3.9, v100)(CUDA 12.0, amd64, Python 3.10, v100)(CUDA 12.2, arm64, Python 3.11, a100)output of print_env.sh (click me)
Other/Misc.
No response
The text was updated successfully, but these errors were encountered: