From 5f488996c2d5d5df655fefcc60bdd0d69bcea03d Mon Sep 17 00:00:00 2001 From: "Mads R. B. Kristensen" Date: Fri, 11 Oct 2024 08:39:23 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Vyas Ramasubramani --- cpp/include/kvikio/remote_handle.hpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/cpp/include/kvikio/remote_handle.hpp b/cpp/include/kvikio/remote_handle.hpp index f5d815cc5f..7d876ab244 100644 --- a/cpp/include/kvikio/remote_handle.hpp +++ b/cpp/include/kvikio/remote_handle.hpp @@ -186,11 +186,11 @@ class S3Endpoint : public RemoteEndpoint { std::optional const& aws_region, std::optional aws_endpoint_url) { - std::string endpoint_url = + auto const endpoint_url = parse_aws_argument(std::move(aws_endpoint_url), "AWS_ENDPOINT_URL", "", true); std::stringstream ss; if (endpoint_url.empty()) { - std::string region = + auto const region = parse_aws_argument(std::move(aws_region), "AWS_DEFAULT_REGION", "S3: must provide `aws_region` if AWS_DEFAULT_REGION isn't set."); @@ -250,17 +250,17 @@ class S3Endpoint : public RemoteEndpoint { std::optional aws_secret_access_key = std::nullopt) : _url{std::move(url)} { - std::string region = + auto const region = parse_aws_argument(std::move(aws_region), "AWS_DEFAULT_REGION", "S3: must provide `aws_region` if AWS_DEFAULT_REGION isn't set."); - std::string access_key = + auto const access_key = parse_aws_argument(std::move(aws_access_key), "AWS_ACCESS_KEY_ID", "S3: must provide `aws_access_key` if AWS_ACCESS_KEY_ID isn't set."); - std::string secret_access_key = parse_aws_argument( + auto const secret_access_key = parse_aws_argument( std::move(aws_secret_access_key), "AWS_SECRET_ACCESS_KEY", "S3: must provide `aws_secret_access_key` if AWS_SECRET_ACCESS_KEY isn't set.");