Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine wheels-pure-publish and wheels-manylinux-publish #78

Closed
vyasr opened this issue May 10, 2023 · 3 comments · Fixed by #89
Closed

Combine wheels-pure-publish and wheels-manylinux-publish #78

vyasr opened this issue May 10, 2023 · 3 comments · Fixed by #89
Assignees

Comments

@vyasr
Copy link
Contributor

vyasr commented May 10, 2023

These two scripts are nearly identical and should be fairly trivial to combine. Currently the only repository making use of the wheels-pure-publish workflow is cudf, and only for dask-cudf. Therefore, I would suggest simply trying to use wheels-manylinux-publish in the dask-cudf workflow, and if that works, switch over the cudf repo to do that and then we can delete the wheels-pure-publish workflow.

Once the two are combined, we should also consider renaming to just wheels-publish.

@shwina
Copy link
Contributor

shwina commented May 15, 2023

@wence- and I noticed while working on this that the scripts rapids-twine and rapids-twine-new are essentially the same. We're just going to use rapids-twine-new in the wheels-publish script. Once we've verified that it works for both "manylinux" and "pure" builds, I think we can go ahead and mv rapids-twine-new rapids-twine.

@vyasr
Copy link
Contributor Author

vyasr commented May 15, 2023

Yes, those two are essentially the same and I was planning on cleaning that up once the dust settled on the current set of in-progress updates to shared workflows and the containers.

vyasr added a commit that referenced this issue Jul 20, 2023
Resolves #78

---------

Co-authored-by: AJ Schmidt <[email protected]>
Co-authored-by: Rick Ratzel <[email protected]>
Co-authored-by: Vyas Ramasubramani <[email protected]>
@vyasr
Copy link
Contributor Author

vyasr commented Jul 24, 2023

Completed in #89 and #116

@vyasr vyasr closed this as completed Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants