Added overload ctor for GpioConnectionSettings for cases when want to set driver manually. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt to set driver manually.
|
Hello, Sorry for the late reply. You should be able to use the existing implementation as follow instead : var settings = new GpioConnectionSettings { Driver = driver }; Is there any issue with that usage ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, guys!
It will be a nice feature to set GpioConnection.Driver instantly in ctor for cases if you want a specific one.
The issue source: for my device administrative model the user stands in gpio group but does not have permission to work with /dev/mem. So, when I create GpioSettings in standard way it causes to pick default driver and crash before settings created.
This tiny impovement is a way fix the situation.