Make receptor angle adjustments to PA consistent with CASA and AIPS #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the ambigous definition of RECEPTOR_ANGLE inside ::FEED to be treated consistently with CASA and AIPS.
|
Let's just at least make this mess self consistent. This is why it is vital to have properly spec'd data structures. |
|
@bmerry as discussed a fix to make this self consistent with the other end-user software |
bmerry
reviewed
Sep 13, 2023
| #dipole phasing calibration ***MUST*** be calibrated prior to applying corrective parallactic angle matrices | ||
| #because the phasing affects the rotation handedness (ie. incorrect phasing results in a sign flip not only | ||
| #on V, but also on U). | ||
| c2, s2 = np.cos(pa[:, aindex, 0]).repeat(nchan), np.sin(pa[:, aindex, 0]).repeat(nchan) |
There was a problem hiding this comment.
Isn't it more direct then just to say
Suggested change
| c2, s2 = np.cos(pa[:, aindex, 0]).repeat(nchan), np.sin(pa[:, aindex, 0]).repeat(nchan) | |
| c2, s2 = c1, s1 |
unless I've missed something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the ambigous definition of RECEPTOR_ANGLE inside ::FEED to be treated consistently with CASA and AIPS.