Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate the database entities to avoid accidental over exposure on WebAPI #25

Closed
AKlaus opened this issue May 27, 2021 · 0 comments · Fixed by #22
Closed

Isolate the database entities to avoid accidental over exposure on WebAPI #25

AKlaus opened this issue May 27, 2021 · 0 comments · Fixed by #22
Labels
back-end Back-end specific issue enhancement New feature or request

Comments

@AKlaus
Copy link
Collaborator

AKlaus commented May 27, 2021

Currently, the database entities (aka "collections") are defined in "Domain" project (along with consumer facing DTOs) that may lead to accidental overexposure of some DB data objects (fully or partially) on the API.

Acceptance criteria

  • Isolate the database models in a separate project (called "Database") that is NOT included in the API project
  • The new "Database" project
    • It's concern is closely coupled with RavenDB - has defined entitles and aggregates along with indexes and the way to connect to the DB;
    • it can be referenced in other projects but as a private reference only (to avoid reference propagation);
  • All shared classes need to go another project
@AKlaus AKlaus added enhancement New feature or request back-end Back-end specific issue labels May 27, 2021
@AKlaus AKlaus linked a pull request May 27, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end Back-end specific issue enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant