[Feature] ObservedGeneration is missing in RayJobStatus

[fscnick]

Search before asking

• I searched the issues and found no similar issues.

KubeRay Component

ray-operator

What happened + What you expected to happen

The ObservedGeneration is missing in RayJobStatus. After searching it, there is ObservedGeneration in the RayJobStatus but no where for updating it.

kuberay/ray-operator/apis/ray/v1/rayjob_types.go

Lines 250 to 253 in d59cbd8

	// observedGeneration is the most recent generation observed for this RayJob. It corresponds to the
	// RayJob's generation, which is updated on mutation by the API Server.
	// +optional
	ObservedGeneration int64 `json:"observedGeneration,omitempty"`

Reproduction script

Create a RayJob and check the RayJobStatus.

Anything else

No response

Are you willing to submit a PR?

• Yes I am willing to submit a PR!

[Future-Outlier]

Hi, @fscnick
Based on the comment below, I think we can wait for users need this.

kuberay/ray-operator/controllers/ray/utils/consistency.go

Lines 9 to 33 in d59cbd8

	// Checks whether the old and new RayClusterStatus are inconsistent by comparing different fields. If the only
	// differences between the old and new status are the `LastUpdateTime` and `ObservedGeneration` fields, the
	// status update will not be triggered.
	//
	// TODO (kevin85421): The field `ObservedGeneration` is not being well-maintained at the moment. In the future,
	// this field should be used to determine whether to update this CR or not.
	func InconsistentRayClusterStatus(oldStatus rayv1.RayClusterStatus, newStatus rayv1.RayClusterStatus) bool {
	if oldStatus.State != newStatus.State || oldStatus.Reason != newStatus.Reason {
	return true
	}
	if oldStatus.ReadyWorkerReplicas != newStatus.ReadyWorkerReplicas ||
	oldStatus.AvailableWorkerReplicas != newStatus.AvailableWorkerReplicas ||
	oldStatus.DesiredWorkerReplicas != newStatus.DesiredWorkerReplicas ||
	oldStatus.MinWorkerReplicas != newStatus.MinWorkerReplicas ||
	oldStatus.MaxWorkerReplicas != newStatus.MaxWorkerReplicas {
	return true
	}
	if !reflect.DeepEqual(oldStatus.Endpoints, newStatus.Endpoints) || !reflect.DeepEqual(oldStatus.Head, newStatus.Head) {
	return true
	}
	if !reflect.DeepEqual(oldStatus.Conditions, newStatus.Conditions) {
	return true
	}
	return false
	}

[Future-Outlier]

If we plan to support this, we should identify user use cases. For example, posting a question in the Ray Slack channel to gather feedback could be a good approach.

[fscnick]

Yep, there is no user report yet. I think it could be waited.

However, there are existed in RayCluster and RayService but missing in RayJob.

kuberay/ray-operator/controllers/ray/raycluster_controller.go

Line 1162 in d59cbd8

newInstance.Status.ObservedGeneration = newInstance.ObjectMeta.Generation

kuberay/ray-operator/controllers/ray/rayservice_controller.go

Line 229 in d59cbd8

rayServiceInstance.Status.ObservedGeneration = rayServiceInstance.ObjectMeta.Generation

[Future-Outlier]

we can refer statefulset source code.