Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[autoscaler][gcp] wrong values for scheduling in example gcp cluster yaml files #46248

Open
guoqiao opened this issue Jun 25, 2024 · 0 comments
Labels
bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component)

Comments

@guoqiao
Copy link

guoqiao commented Jun 25, 2024

What happened + What you expected to happen

In python/ray/autoscaler/gcp/*.yaml files, the scheduling field is configured as following in a few places:

scheduling:
  - preemptible: true
  - onHostMaintenance: TERMINATE

The equivalent json version will be:

"scheduling": [
    {"preemptilbe": true},
    {"onHostMaintenance": "TERMINATE"}
]

This is wrong, according to GCP Doc:

"scheduling": {
    "onHostMaintenance": enum,
    "automaticRestart": boolean,
    "preemptible": boolean,
    ...
}

Summary: for gcp, scheduling should be object/dict, but misconfigured to be a list of objects in examples.

Versions / Dependencies

all versions up to lastest (2.24)

Reproduction script

in repo root:

cd python/ray/autoscaler/gcp/
grep -A 3 "scheduling:" *.yaml

Issue Severity

Low: It annoys or frustrates me.

@guoqiao guoqiao added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component)
Projects
None yet
Development

No branches or pull requests

1 participant