Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serve] does not work with tracing #46252

Open
judahrand opened this issue Jun 25, 2024 · 1 comment
Open

[Serve] does not work with tracing #46252

judahrand opened this issue Jun 25, 2024 · 1 comment
Labels
bug Something that is supposed to be working; but isn't core Issues that should be addressed in Ray Core P1 Issue that should be fixed within a few weeks serve Ray Serve Related Issue

Comments

@judahrand
Copy link

judahrand commented Jun 25, 2024

What happened + What you expected to happen

When enabling tracing on a Ray Serve deployment I get an error:

(ProxyActor pid=71635) WARNING 2024-06-25 17:52:09,114 proxy 127.0.0.1 pow_2_scheduler.py:536 - Failed to fetch queue length for Replica(id='ukdreh12', deployment='Deployment', app='default'): 'got an unexpected keyword argument '_ray_trace_ctx''

I'd hoped that tracing would just work with Ray Serve so that I could set up OTEL traces.

Versions / Dependencies

ray==2.30.0

Reproduction script

from typing import Any

import ray
import ray.serve
import requests


ray.init(
    _tracing_startup_hook='ray.util.tracing.setup_local_tmp_tracing:setup_tracing',
)


@ray.serve.deployment
class Deployment:
    def __call__(self, *args: Any, **kwargs: Any) -> str:
        return 'Hello, world!'


app = Deployment.bind()
ray.serve.run(app)

requests.post('http://localhost:8000', json={})

Issue Severity

High: It blocks me from completing my task.

@judahrand judahrand added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Jun 25, 2024
@anyscalesam anyscalesam added P1 Issue that should be fixed within a few weeks serve Ray Serve Related Issue core Issues that should be addressed in Ray Core and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Jul 1, 2024
@anyscalesam
Copy link
Collaborator

@judahrand - yeah we're aware - working on restoring Open Telemetry working again. Would you be interested in contributing; we're working on an RFC that we'll publish but need help in implementing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't core Issues that should be addressed in Ray Core P1 Issue that should be fixed within a few weeks serve Ray Serve Related Issue
Projects
None yet
Development

No branches or pull requests

2 participants